audio: pipeline-schedule: make pipeline_schedule_triggered() user safe#10993
Open
kv2019i wants to merge 1 commit into
Open
audio: pipeline-schedule: make pipeline_schedule_triggered() user safe#10993kv2019i wants to merge 1 commit into
kv2019i wants to merge 1 commit into
Conversation
Add support to run pipeline_schedule_triggered() in user-space. Use the user_ll_lock/unlock_sched() interface if building with CONFIG_SOF_USERSPACE_LL. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
Author
|
For context, related to #10558 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates pipeline_schedule_triggered() to be callable from user-space builds by replacing the kernel-only IRQ critical section (irq_local_disable()/enable()) with the user-space LL scheduler lock (user_ll_lock_sched()/unlock_sched()) when CONFIG_SOF_USERSPACE_LL is enabled.
Changes:
- Add
CONFIG_SOF_USERSPACE_LLlocking path usinguser_ll_lock_sched()/user_ll_unlock_sched()around pipeline trigger scheduling. - Keep the existing IRQ-disable critical section for kernel-space builds.
| */ | ||
| int sched_core = ppl_data->start->ipc_config.core; | ||
|
|
||
| user_ll_lock_sched(sched_core); |
Comment on lines
+293
to
+296
| int sched_core = ppl_data->start->ipc_config.core; | ||
|
|
||
| user_ll_lock_sched(sched_core); | ||
| #else |
lyakh
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support to run pipeline_schedule_triggered() in user-space. Use the user_ll_lock/unlock_sched() interface if building with CONFIG_SOF_USERSPACE_LL.