SCAL-326328 Fixed Flag is not passing when preRender when is true in full app emebd - #595
Open
shivam-kumar-ts wants to merge 2 commits into
Open
SCAL-326328 Fixed Flag is not passing when preRender when is true in full app emebd#595shivam-kumar-ts wants to merge 2 commits into
shivam-kumar-ts wants to merge 2 commits into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
AppEmbedonly overrodegetEmbedParams()(returns a string), notgetEmbedParamsObject()(returns an object).The prerender path calls
getUpdateEmbedParamsObject()→this.getEmbedParamsObject(). SinceAppEmbednever overrodegetEmbedParamsObject(), it fell back to the base class which has no fullHeight logic — soisFullHeightPinboardwas never set inUpdateEmbedParams.LiveboardEmbedwas fine because it already overrodegetEmbedParamsObject().Fix
Split
AppEmbed.getEmbedParams()into:getEmbedParamsObject()— builds and returns the params object (withParam.fullHeight→isFullHeightPinboard)getEmbedParams()— callsgetEmbedParamsObject()and converts to query stringNow both the normal render path (
getEmbedParams) and the prerender path (getUpdateEmbedParamsObject→getEmbedParamsObject) go through the same function, soisFullHeightPinboardis correctly populated in both cases.