SCAL-326416: remove radiant icon id fields from Spotter embed config - #598
Merged
Conversation
Hosts cannot discover radiant icon ids — they are internal and unpublished — and icon overrides already work through customizations.iconSpriteUrl. Drops SpotterChatPinConfig.icon, spotterShareIcon and spotterShareGroupIcon. All three are unreleased (latest published SDK is 1.50.1), so no deprecation cycle is needed.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
commit: |
sandeep-kr-yadav
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes three icon-id config fields from the Spotter embed surface:
SpotterChatPinConfig.icon,spotterShareIcon,spotterShareGroupIcon.Radiant icon ids are internal and unpublished, so hosts have no way to discover valid values. Icon overrides already work via
customizations.iconSpriteUrl(customize-icons), which needs no per-feature config.