[WEB-4585, 4577, 4578] - Carb Modifications + Device Names + Deduplicate Healthkit#87
[WEB-4585, 4577, 4578] - Carb Modifications + Device Names + Deduplicate Healthkit#87henry-tp wants to merge 4 commits into
Conversation
henry-tp
changed the title
| stats: this.getStatsByChartType('basics', data), | ||
| excludeDaysWithoutBolus: false, | ||
| bgPrefs: this.getBGPrefs(), | ||
| metaData: 'latestPumpUpload, bgSources', |
There was a problem hiding this comment.
Mirrors this change which was needed to get the correct device name:
henry-tp
changed the title
henry-tp
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the export/report generation pipeline to support newer Tidepool Viz report behavior (carb modifications, device name metadata, and HealthKit deduplication) by upgrading @tidepool/viz and requesting additional metadata in report queries.
Changes:
- Bump
@tidepool/vizfrom1.53.0-rc.1to1.56.0(and updateyarn.lockaccordingly). - Request additional DataUtil metadata (
devices,matchedDevices) in all report query definitions. - Update report query expectations in
test/report.test.jsto match the new metadata request.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
package.json |
Upgrades @tidepool/viz dependency to 1.56.0. |
yarn.lock |
Locks the upgraded @tidepool/viz@1.56.0 resolution and checksum. |
lib/report.mjs |
Expands metaData requested by report queries to include devices and matchedDevices. |
test/report.test.js |
Updates expected report query objects to include the expanded metaData string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| metaData: 'latestPumpUpload, bgSources', | ||
| metaData: 'latestPumpUpload, bgSources, devices, matchedDevices', | ||
| timePrefs: this.getTimePrefs(), | ||
| excludedDevices: [], |
There was a problem hiding this comment.
We need to allow Viz to run the code that detects and sets the excludedDevices by not forcing through this argument of [].
However, Viz will usually just use its fallback arg of []
WEB-4585
WEB-4577
WEB-4578