Add profiling_frameptr feature for jemalloc --enable-prof-frameptr#171
Open
ArniDagur wants to merge 1 commit into
Open
Add profiling_frameptr feature for jemalloc --enable-prof-frameptr#171ArniDagur wants to merge 1 commit into
profiling_frameptr feature for jemalloc --enable-prof-frameptr#171ArniDagur wants to merge 1 commit into
Conversation
|
Welcome @ArniDagur! It looks like this is your first PR to tikv/jemallocator 🎉 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds a new Changesprofiling_frameptr feature addition
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Similar to tikv#159, we introduce `profiling_frameptr` to enable frame-pointer based profiling via `--enable-prof-frameptr`. This option was introduced in jemalloc/jemalloc#2712, which was released as a part of `5.3.1`. We make `profiling_frameptr` mutually exclusive with `profiling_libunwind`, since jemalloc configures just a single backtrace method, and we don't want it to silently prefer one over the other. Signed-off-by: Arni Dagur <adg@adg.is>
ArniDagur
force-pushed
the
profiling-frameptr
branch
from
453356d to
d6f8285
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@jemalloc-sys/build.rs`:
- Around line 321-328: The `profiling_frameptr` branch in `build.rs` currently
gates `--enable-prof-frameptr` only on `target`, so a non-Linux build host can
still pass a flag that jemalloc ignores. Update the `profiling_frameptr`
handling to check `host` (or both `host` and `target`) before calling
`cmd.arg("--enable-prof-frameptr")`, and keep the existing `info!`/panic
behavior aligned with the new host-based gate.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6c8e4ae1-7835-4ab2-ad50-850933ec51f2
📒 Files selected for processing (5)
jemalloc-ctl/Cargo.tomljemalloc-sys/Cargo.tomljemalloc-sys/README.mdjemalloc-sys/build.rsjemallocator/Cargo.toml
BusyJay
reviewed
Jul 1, 2026
| // wins over frameptr if both are enabled. We make them mutually exclusive to | ||
| // avoid confusion resulting from configuration priority. | ||
| if profiling_libunwind && profiling_frameptr { | ||
| panic!( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #159, we introduce
profiling_frameptrto enable frame-pointer based profiling via--enable-prof-frameptr.This option was introduced in jemalloc/jemalloc#2712, which was released as a part of
5.3.1.We make
profiling_frameptrmutually exclusive withprofiling_libunwind, since jemalloc configures just a single backtrace method, and we don't want it to silently prefer one over the other.Summary by CodeRabbit