test: cover shader compilation script regressions#268
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
scripts/compile_shaders.shargument validation for--generated-dir--applyreplacement behavior with backups of previous tracked shader blobs.spvfilesTest files added/updated
tests/scripts/test_compile_shaders_regressions.shtest_compile_shaders_regressionsinCMakeLists.txttests/README.mdWhy this reduces regression risk
The shader compilation script sits on the renderer build path and recently gained/changed RTX embed and generated-shader behavior. The new fixture test runs the script end-to-end without requiring Vulkan SDK tools or GPU hardware, so CI can catch script regressions before they corrupt generated shader blobs or omit embedded RTX shader data.
Validation
tests/scripts/test_compile_shaders_regressions.sh scripts/compile_shaders.shcmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFF && ctest --test-dir build-coverage-tests -R test_compile_shaders_regressions --output-on-failurectest --test-dir build-coverage-tests -R 'test_compile_(engine_lto|shaders_regressions)' --output-on-failure