Flatten all matching gamePk highlights across dates#172
Open
ty-porter wants to merge 2 commits into
Open
Conversation
WardBrian
reviewed
Jun 2, 2026
| .get("highlights", {}) | ||
| ) | ||
|
|
||
| gameHighlights = { "items": [] } |
Collaborator
There was a problem hiding this comment.
adding these to a dictionary seems a bit silly, since they just get pulled out on line 1079. A list would do, and would simplify some of the following code
Author
There was a problem hiding this comment.
Fair, spent some time untangling the rest of the implementation. This should be cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #164
gamePkis the unique ID for a game even across multiple dates, such as the example where a rainout moves the game to a later date. This causes the first game to have empty highlights, but the second has actual data.This change allows
game_highlight_data()to grab every highlight across multiple dates and flatten them into a single list.