Deprecate nested for no_multi#346
Merged
Merged
Conversation
Owner
|
Thank you! I'll merge that one later! Sorry for taking my time. Because of the heat here I am rarely on the PC at the moment outside of working hours |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the command "nested" to "no_multi" (variants and overrides each), as "nested" seems to confuse people about the meaning (seen by complaints and common use on singular factorials).
As suddenly changing it would break usage, the old commands are kept, but a note is added directing to the new commands.
Even though it logically shouldn't be, this technically is a breaking change for the library, as I had previously forgotten to mark the locale as non-exhaustive (and add the Default derive). With these changes now done, future additions to locale will not be breaking changes.