fix: validate negative input in factorialRecursive function#2197
Open
REAPER2705 wants to merge 1 commit into
Open
fix: validate negative input in factorialRecursive function#2197REAPER2705 wants to merge 1 commit into
REAPER2705 wants to merge 1 commit into
Conversation
REAPER2705
commented
Jul 19, 2026
REAPER2705
commented
- Add input validation to throw an error for negative numbers
- Update JSDoc to document the thrown error
- Prevent incorrect behavior where negative inputs would return 1
- Add input validation to throw an error for negative numbers - Update JSDoc to document the thrown error - Prevent incorrect behavior where negative inputs would return 1
daltino
approved these changes
Jul 19, 2026
daltino
left a comment
daltino
left a comment
There was a problem hiding this comment.
This PR ensures the factorialRecursive function properly validates negative input by throwing an error, which improves its reliability and aligns with mathematical conventions. The change is concise, follows the existing code style, and doesn't introduce issues based on the diff. However, confirm that tests for this validation exist or are added as required by the contribution guidelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.