Skip to content

docs(flaky-tests): document fork PR uploads per-repo opt-in#33

Merged
samgutentag merged 1 commit into
mainfrom
sam-gutentag/flaky-tests-fork-pr-uploads
Jun 1, 2026
Merged

docs(flaky-tests): document fork PR uploads per-repo opt-in#33
samgutentag merged 1 commit into
mainfrom
sam-gutentag/flaky-tests-fork-pr-uploads

Conversation

@samgutentag
Copy link
Copy Markdown
Member

Summary

  • Adds a new "Uploading from Fork Pull Requests" section to flaky-tests/get-started/multiple-repositories.mdx
  • Explains how to enable the Fork PR Uploads toggle in repo settings to get a public repo identifier
  • Documents the workflow YAML change that uses public-repo-id instead of the org API token
  • Covers the two-part authorization model (opt-in + GitHub run verification)
  • Includes a warning about rotating the identifier if misused

Source

Test plan

  • Check Mintlify preview link (posted on the PR by the Mintlify GitHub app)
  • Verify the new section renders correctly (callout blocks, code block, warning)
  • Confirm the section flows correctly after "How Repository Identification Works"

Generated by Claude Code

@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented May 19, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
trunk 🟢 Ready View Preview May 19, 2026, 11:01 AM

@samgutentag samgutentag changed the title docs(flaky-tests): document fork PR uploads per-repo opt-in [blocked] docs(flaky-tests): document fork PR uploads per-repo opt-in May 19, 2026
@samgutentag
Copy link
Copy Markdown
Member Author

samgutentag commented May 19, 2026

Verification status (2026-05-19): blocked

Eng PR not merged. Hold.

  • Eng PR: trunk2#3908 (merged 2026-05-18). Cross-repo deps still OPEN:
    • analytics-cli#1086 (Support X-Trunk-Public-Repo-Id auth for fork PRs)
    • trunk#31970 (Accept X-Trunk-Public-Repo-Id on flaky-tests upload + quarantine endpoints)
  • Flag: none (no LaunchDarkly flag introduced in trunk2#3908)
  • Signals: trunk2 UI toggle ships ungated, but the documented workflow YAML depends on analytics-cli sending the new header and the monolith accepting it. Neither merged at this sweep.

Hold until analytics-cli#1086 and trunk#31970 merge.

Note: PR #35 also documents this feature with a slightly different scope. Coordinate which docs PR to merge.

Label: awaiting eng.

@samgutentag samgutentag added the awaiting eng Verify docs PR: eng PR not merged. Hold. label May 19, 2026
@samgutentag samgutentag changed the title [blocked] docs(flaky-tests): document fork PR uploads per-repo opt-in docs(flaky-tests): document fork PR uploads per-repo opt-in May 19, 2026
@samgutentag samgutentag added pending Verify docs PR: eng merged but flag off in prod. Hold off. and removed awaiting eng Verify docs PR: eng PR not merged. Hold. labels May 20, 2026 — with Claude
Copy link
Copy Markdown
Member Author

samgutentag commented May 20, 2026

Verification status (2026-05-29): blocked

Eng PR not merged. Hold.

  • Flag state: read directly from LaunchDarkly (none to read; feature is ungated, no LaunchDarkly flag in trunk2#3908). LD MCP confirmed reachable this sweep.
  • Eng PR: trunk-io/trunk2#3908 (merged 2026-05-18, merge commit on main). Cross-repo deps:
  • Flag: none
  • Signals: The documented customer workflow YAML pastes the public repo identifier and relies on analytics-cli sending it on the X-Trunk-Public-Repo-Id header. The monolith now accepts that header (trunk#31970 merged), but the CLI still does not send it (analytics-cli#1101 open). End-to-end the fork-PR upload path is not functional for customers yet.

Progress since last sweep: the monolith half (trunk#31970) shipped. Remaining blocker is the CLI half (analytics-cli#1101). Hold until #1101 merges and ships in a released CLI version.

Note: PR #35 also documents this feature with a slightly different scope. Coordinate which docs PR to merge.

Label: awaiting eng.

@samgutentag samgutentag added awaiting eng Verify docs PR: eng PR not merged. Hold. and removed pending Verify docs PR: eng merged but flag off in prod. Hold off. labels May 26, 2026
Adds a new "Uploading from Fork Pull Requests" section to the
multiple-repositories page explaining how to enable the settings toggle,
copy the public repo identifier, and configure fork PR workflows to upload
test results without exposing the org API token.

Source: trunk-io/trunk2#3908

Co-Authored-By: Claude <noreply@anthropic.com>
@samgutentag samgutentag force-pushed the sam-gutentag/flaky-tests-fork-pr-uploads branch from 34bfb2d to 4fd456a Compare May 26, 2026 20:08
@samgutentag samgutentag added ready to merge Verify docs PR: customers can use this. Ready to publish. and removed awaiting eng Verify docs PR: eng PR not merged. Hold. labels May 30, 2026 — with Claude
Copy link
Copy Markdown
Member Author

Verification status (May 30, 2026): live

Verified: customers can use this. Ready to publish.

  • Flag state: LaunchDarkly not consulted (no flag gates this feature).
  • Eng PR: trunk-io/trunk2#3908 (merged 2026-05-18, intact on main), trunk-io/trunk#31970 (merged 2026-05-28), Support uploading from forked-repo PRs via x-trunk-public-repo-id analytics-cli#1101 (merged 2026-05-29).
  • Flag: none.
  • Signals: Slack #merge-notifications confirmed analytics-cli#1101 "Support uploading from forked-repo PRs via x-trunk-public-repo-id" merged 2026-05-29 at 11:48 PDT. The prior blockers (CLI not sending the header, monolith not accepting it) are both resolved.

Prior verdict was blocked because analytics-cli#1101 was still open. It merged yesterday. The complete fork PR upload path is now live in production. Note: PR #35 also documents this feature with overlapping content on the same page. Coordinate before publishing.


Generated by Claude Code

Copy link
Copy Markdown
Member Author

Verification status (May 31, 2026): live

The blocking analytics-cli dependency has merged; fork PR upload docs (per-repo flow) are clear to ship.

  • Flag state: not consulted
  • Eng PRs: trunk2#3908 (merged May 18), trunk#31970 (merged May 28), analytics-cli#1101 (merged May 29)
  • Flag: none
  • Signals: all three cross-repo blocking PRs landed; feature live in prod since May 30

Next action: merge this PR.


Generated by Claude Code

Copy link
Copy Markdown
Member Author

Docs Verify Sweep · June 1, 2026 · ✅ live

Feature is live in production. Ready to merge.

Unchanged from previous sweep (May 31, 2026).


Generated by Claude Code

@samgutentag samgutentag marked this pull request as ready for review June 1, 2026 20:51
@samgutentag samgutentag merged commit 255d30d into main Jun 1, 2026
3 checks passed
samgutentag added a commit that referenced this pull request Jun 1, 2026
…rotation

Merges #35's fuller content into the section #33 added to main, leaving one
fork-PR section instead of two overlapping ones. Adds the why (fork
pull_request workflows run read-only and can't read secrets), the public vs
private guidance, and a raw-CLI alternative (--public-repo-id /
TRUNK_PUBLIC_REPO_ID, sent on the X-Trunk-Public-Repo-Id header).

Fixes the rotation claim: the prior <Warning> said re-enabling mints a new
identifier and invalidates the old one. Source (frontend
fork-pr-uploads.ts upsert) only generates publicRepoIdentifier on row
create; the enable/disable update never touches it, so the identifier
persists and is reused on re-enable. Verified the action input
(analytics-uploader action.yaml: public-repo-id) and CLI flag
(analytics-cli upload_command.rs: public_repo_id) both exist.

Drops #### subheadings for bold-lead paragraphs to keep the page at h3.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
samgutentag added a commit that referenced this pull request Jun 1, 2026
…rotation (#35)

Merges #35's fuller content into the section #33 added to main, leaving one
fork-PR section instead of two overlapping ones. Adds the why (fork
pull_request workflows run read-only and can't read secrets), the public vs
private guidance, and a raw-CLI alternative (--public-repo-id /
TRUNK_PUBLIC_REPO_ID, sent on the X-Trunk-Public-Repo-Id header).

Fixes the rotation claim: the prior <Warning> said re-enabling mints a new
identifier and invalidates the old one. Source (frontend
fork-pr-uploads.ts upsert) only generates publicRepoIdentifier on row
create; the enable/disable update never touches it, so the identifier
persists and is reused on re-enable. Verified the action input
(analytics-uploader action.yaml: public-repo-id) and CLI flag
(analytics-cli upload_command.rs: public_repo_id) both exist.

Drops #### subheadings for bold-lead paragraphs to keep the page at h3.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Verify docs PR: customers can use this. Ready to publish.

Development

Successfully merging this pull request may close these issues.

2 participants