Remove the vpicc and virt features that are used for testing and should not be public - #42
Merged
sosthene-nitrokey merged 13 commits intoAug 6, 2026
Merged
Conversation
Contributor
Author
|
Tests pass locally, the CI still needs to be updated with an image that includes opensc and pivy. |
robin-nitrokey
approved these changes
Aug 5, 2026
sosthene-nitrokey
force-pushed
the
vpicc-clean
branch
11 times, most recently
from
August 6, 2026 15:07
c0c3590 to
082432f
Compare
Contributor
Author
|
Making the CI run full was a mess but it's working now. |
This allows us to still have warnings for internal code
sosthene-nitrokey
force-pushed
the
vpicc-clean
branch
from
August 6, 2026 15:29
082432f to
4e52705
Compare
robin-nitrokey
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.