Trixie release#24
Open
JedMeister wants to merge 100 commits into
Open
Conversation
- add 'turnkey-pypy2' as tklbam as build & install dependency - remove pypy download related bits from duct-tape-deps.sh
tar should always be installed by default, but better to be explicit
- use DEPROOT_LIB env var for lib path; rather than DEPROOT - set DEPROOT_BIN env var for dependency bin/ path - remove unused HOST_ARCH var - set PYPY_BIN var; pypy bin directory - which is also LD_LIBRARY_PATH - set PYPY_CMD var; pypy executable - search for executable files in built dependencies and move any found to DEPROOT_BIN - check for new TKL source git repo "master" branch commits and warn if saved commit ID does not match HEAD - but still build from saved commit ID
… need more tweaks
…s also called duplicity)
To use requires:
- if not using default AWS region:
AWS_REGION=...
- TKLBAM_BUCKET=s3://<bucket>/<path>
i.e.:
- no domain
- not 's3://s3-<region>-amazonaws.com/<bucket>/<path>'
70 tasks
OnGle
suggested changes
Jun 12, 2026
OnGle
left a comment
OnGle
left a comment
Member
There was a problem hiding this comment.
Everything looks good. I would like to know what the context of that commented out code is, but assuming it's not important/wasn't intentional I wouldn't consider that a merge-blocker.
Comment on lines
+97
to
+108
| #if exists("/var/lib/tklbam/iam_role"): | ||
| # with open("/var/lib/tklbam/iam_role") as fob: | ||
| # self.env['AWS_ROLE_ARN'] = fob.read().strip() | ||
| #else: | ||
| # print "WARNING /var/lib/tklbam/iam_role not found" | ||
| # print "Not setting AWS_ROLE_ARN env var" | ||
| # accesskey, secretkey, sessiontoken, expiration | ||
| env['AWS_ACCESS_KEY_ID'] = creds["accesskey"] | ||
| env['AWS_SECRET_ACCESS_KEY'] = creds["secretkey"] | ||
| env['AWS_SESSION_TOKEN'] = creds["sessiontoken"] | ||
| # this isn't actually used, but for good measure... | ||
| #env['AWS_SESSION_EXPIRATION'] = creds["expiration"] |
Member
There was a problem hiding this comment.
Is there any context on this commented code?
Member
|
Whoops, that was meant to be an accept of the PR, not a request changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Huge changes for v19.0 release...
Primarily to support use of pypy2 (previously used python2), pull in libs from turnkey-pylib and other required dependencies (external deps pulled in at build time).