Redesign state-owned invocation API - #110
Merged
Merged
Conversation
SandroMaglione
marked this pull request as ready for review
August 15, 2026 04:14
Contributor
Type performanceMeasured with TypeScript 6.0.3 and
Marginal instantiations are measured against the matching setup without that API call:
Check times (informational)
Type instantiations are the comparison metric. Check time varies with runner load and is informational only. |
Contributor
Runtime performanceMedian of 5 independent benchmark processes on Pull request baseline
Process runtime reference points
Effect Machine change from base
Process runtime reference change from base
Regression guardNo large, noise-adjusted throughput or heap regressions detected. Versions and interpretation
Higher throughput is better; lower heap is better. Variability is the median absolute deviation across independent processes, relative to their median. Small differences on shared GitHub-hosted hardware remain informational; the required guard rejects only large changes beyond the measured noise allowance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Machine.invokeEffect,Machine.after,Machine.invokeMachine, andMachine.effectwith one state-owned inline invocation model foreffect,after,logic, andchildsourcesonDone,onFailure, andonSnapshotoutcomes through direct owning-state transitions, with source/initialization failures, defects, and interruption failing the machineChangeset
src/orpackage.jsonMinor changeset added for the pre-1.0 breaking API change.
Validation
pnpm checkExample checks passed for
platformer,playground, andpokemonagainst the packed declarations. Localpnpm perf:typesstayed within configured instantiation budgets, including a new state-dependentMachine.invokescenario at 65,033 total / 57,838 marginal instantiations.Local
pnpm perf:runtimecompleted successfully. The authoritative five-process PR comparison reports no large noise-adjusted regressions. The previously failing parent/child start-stop scenario is now 7.1% faster thanmain, while its idle heap is 1.1% higher; the largest remaining observed heap difference is 5.7% for invoked-child snapshot observation, within the guard.