Update dependencies passkit#109
Merged
Merged
Conversation
Owner
|
Hey, thanks for the contribution! Can you please revert all changes except for pointy castle? The other increases in the min version (except pointy castle) just decrease the overall compatibility of the package without any upside since the newest versions of them are already compatible. In packages you want to support an as wide as possible version range for your dependencies which is a contrast to apps, where you typically just want to use the latest. |
Contributor
Author
|
Sure |
Contributor
Author
|
Ok, I revert all changes except for pointy castle. |
Owner
|
Awesome thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ueman, How's going?
I'm going to use the package on my project and I'm contribute with a update packages.
Thanks