-
Notifications
You must be signed in to change notification settings - Fork 82
Added Webclient, refactored Webserver to share streamed body sending and receiving logic. #2771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jurgenvinju
wants to merge
70
commits into
main
Choose a base branch
from
feat/webclient
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,356
−1,027
Draft
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
cdb31e4
added initial webclient API that mirrors the Webserver API and uses t…
jurgenvinju b0c95c2
cleanup and added POST method
jurgenvinju f93bc31
added the other methods
jurgenvinju f596732
added progress bar
jurgenvinju 5a10d11
fixed post
jurgenvinju 3058f74
constructor typo
jurgenvinju a3a1bad
fix post bug
jurgenvinju 7092ce8
added path to other requests kinds but GET and POST
jurgenvinju 99ca901
Merge branch 'main' into feat/webclient
jurgenvinju a7dfdf9
started rewrite of Server and Client interface to canonically treat a…
jurgenvinju 3e89716
big cleanup of Webclient, but Webserver is broken now and I still hav…
jurgenvinju 0ea8d9c
debugging with @davylandman
jurgenvinju 73dd585
linked up the Subscription API as well to complete the stream
jurgenvinju 3bef1c0
improving error handling of common mistakes in the client
jurgenvinju 7ec7468
factored out Writer-based suppliers
jurgenvinju d4d1e68
added asserts to diagnose possible race
jurgenvinju aba5882
error handling for bad URLs
jurgenvinju f16c064
removed dead use of parameter
jurgenvinju c197d9d
this seems to have fixed the race
jurgenvinju 8ec4c70
comments
jurgenvinju f8f500c
deal with null messages of IOException generally
jurgenvinju 39c0744
fixed off-by-one in download progress
jurgenvinju 8d717be
rewrote the webserver side to accept the new Body constructors send a…
jurgenvinju 5326eb7
server is working again
jurgenvinju df1b0e7
added xml and html sending and receiving, only server side reception …
jurgenvinju 74f4b12
refactoring that factors common WriterToInputStream functionality int…
jurgenvinju e26aa14
fixing issues with module management in client and server
jurgenvinju d4e5744
rationalized JSON options
jurgenvinju 5f04d79
cleanup of Webservice module and added some example usages
jurgenvinju 84cf3ee
linked charset parameter of POST and PUT bodies
jurgenvinju a756cc1
finished charset and mimetype propagation to POSt and PUT headers
jurgenvinju c6d9105
wired server side mimeType and response for bodies
jurgenvinju ac6fd35
fixed copy/paste bug
jurgenvinju d36874e
fixed switch case missing break bug
jurgenvinju dca2731
added missing file
jurgenvinju 3902b73
added more headers
jurgenvinju 227cc57
Merge branch 'main' into feat/webclient
jurgenvinju 566b6c5
fixing more comments by @davylandman
jurgenvinju 74fcc9f
wrote a test server that does not lock the interpreter but does use a…
jurgenvinju 5869541
some fixes. not yet working
jurgenvinju 04c9185
test servers are working
jurgenvinju 7a0e98a
writing first good tests. they still fail
jurgenvinju d0fa8f9
fixing things one-by-one
jurgenvinju e28f908
fixed sloppy NPEs
jurgenvinju d0bf6fc
fixed content-type for POST and PUT bodies in client
jurgenvinju 22bf4c4
big rewrite to Undertow modern HTTP server in Java, removed clone of …
jurgenvinju 8c05cb5
cleaning up
jurgenvinju ceefc0f
one more compilation error
jurgenvinju 46a9c0e
fixed some warnings to get overview back
jurgenvinju e12c7c1
bumped to Java 17 because Undertow requires it
jurgenvinju 907c3d0
solved issues with new yield keyword in Java 17
jurgenvinju 4815bec
bumped action workflow to Java 17
jurgenvinju 90fcc58
fixing stuff after jump to Java 17
jurgenvinju cd3144b
some more fixes to get the server working again. almost there
jurgenvinju d5ee144
fixes and cleanup
jurgenvinju 4881bc6
can call test server with builtin client
jurgenvinju ce65528
fixed sending and receiving HTMLElement instances over http (client/s…
jurgenvinju 1dc3427
added XML roundtrip testing
jurgenvinju 64d2945
fixed XML roundtripping
jurgenvinju 2043955
added HTMLOptions for later use by requests
jurgenvinju d79f5bf
rationalized and finished JSON options
jurgenvinju 2e423b6
threaded HTML options
jurgenvinju 570876d
streamed XML options too
jurgenvinju 74b5d4c
added xmlOptions to BodyKind
jurgenvinju bb25e65
enabled automatic port allocation for util::Webserver
jurgenvinju e6be501
added precision parameter
jurgenvinju 45b1d77
added precision parameter
jurgenvinju 93ce12e
workaround
jurgenvinju 0cb24c8
a rather difficult merge
jurgenvinju aeeefd3
Merge branch 'main' into feat/webclient
jurgenvinju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is superfluous now