Refine deterministic VMEC events - #55
Draft
rogeriojorge wants to merge 1 commit into
Draft
Conversation
eduardolneto
approved these changes
Aug 12, 2026
eduardolneto
left a comment
eduardolneto
left a comment
Contributor
There was a problem hiding this comment.
Changes seem good for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines magnetic-axis and LCFS event times for deterministic VMEC guiding-center traces. Fixed and adaptive ODE models use one continuous radial event with Newton interpolation. Collision models keep step-end event detection.
Initial markers outside the radial interval now raise an input error. The QP trace kept 8 axis hits and 90 boundary hits; termination states were within
8e-16of their radial surface.Cold tracing time was 6.12 s, compared with 5.53 s on the parent branch. Peak resident memory was 772 MB, compared with 758 MB.
Depends on #54. No test files changed.