chore: remove redundant overrides and set chart defaults#99
Merged
Conversation
- Remove `source: redhat-operators` (upstream default) from 8 subscriptions - Remove `installPlanApproval: Automatic` (upstream default) from lvm-operator, cnv - Remove `#upstream config` comments from namespace fields - Add missing `project: sandbox` to sandbox-policies in 3 files - Fix trailing whitespace on `installPlanApproval: Manual` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The sandboxed-containers chart only uses secretStore.name/kind in ssh-key-eso.yaml, which is triple-gated on enableSSHDebug AND backend != none AND clusterPlatform == Azure. On baremetal, this template never renders, making these overrides dead code. global.secretStore.backend is also redundant — already set in values-global.yaml and propagated via clustergroup helm parameters. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Set chart defaults to vault-backend/ClusterSecretStore instead of empty strings. Child apps receive the global secretStore via values-global.yaml (included in every app's valueFiles by the clustergroup chart), so inline overrides in the topology file are redundant. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source: redhat-operatorsfrom 8 subscriptions (upstream default)installPlanApproval: Automaticfrom lvm-operator, cnv (global default)#upstream configcomments from namespace fieldsproject: sandboxto sandbox-policies app in 3 topology filessecretStoreoverrides from baremetal sandbox app (template never renders on baremetal)secretStoredefaults tovault-backend/ClusterSecretStoreinstead of empty strings, removing need for inline overridesTest plan
🤖 Generated with Claude Code