Release v4 hardening and hosted deploy#36
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (78)
📝 WalkthroughWalkthroughThis PR adds sandbox concurrency limiting, subprocess worker reuse with memory sizing, a local-runtime safety warning/restriction, ChangesSandbox Runtime, Concurrency, and Worker Reuse
Estimated code review effort: 4 (Complex) | ~60 minutes Deployment Logs and Database Virtual Procedure Refactor
Estimated code review effort: 4 (Complex) | ~45 minutes Deployment Rollout Polling Budget Handling
Estimated code review effort: 3 (Moderate) | ~25 minutes HTTP Server Session Serialization and Origin Warning
Estimated code review effort: 3 (Moderate) | ~20 minutes Docker, CI, Docs, and Version 4.0.0 Release Prep
Estimated code review effort: 2 (Simple) | ~15 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Added a new script `check-openapi-drift.mjs` to verify discrepancies between the vendored OpenAPI specification and the latest public versions. - Introduced a GitHub Actions workflow for scheduled OpenAPI drift checks. - Updated `package.json` to include a new command for the drift check. - Revised `README.md` and `coverage.md` to reflect the updated API procedures and tags, now totaling 544 procedures and 50 tags. - Enhanced the OpenAPI schema to include new fields and ensure consistency across various deployment configurations.
vcode-sh
marked this pull request as ready for review
July 9, 2026 14:25
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fda1a1f7c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+137
to
+141
| hasDrift: | ||
| addedOperations.length > 0 || | ||
| removedOperations.length > 0 || | ||
| addedTags.length > 0 || | ||
| removedTags.length > 0, |
There was a problem hiding this comment.
When upstream changes an existing operation's parameters, request schema, or response schema without adding/removing a path or tag, this check still returns hasDrift: false because it only compares operation and tag sets. That lets the scheduled drift workflow pass while the generated runtime schemas and SDK remain stale for changed endpoints; include a canonical spec/schema hash or per-operation schema comparison in the drift decision.
Useful? React with 👍 / 👎.
| USER node | ||
| EXPOSE 3000 | ||
|
|
||
| HEALTHCHECK --interval=30s --timeout=5s --start-period=10s --retries=3 CMD ["node", "-e", "fetch('http://127.0.0.1:3000/health').then((r)=>{if(!r.ok)process.exit(1)}).catch(()=>process.exit(1))"] |
There was a problem hiding this comment.
When an operator overrides DOKPLOY_MCP_HTTP_PORT or DOKPLOY_MCP_HEALTH_PATH for the image, the server listens on the configured endpoint but this exec-form healthcheck still probes 127.0.0.1:3000/health, so otherwise healthy containers are marked unhealthy. Use a shell-form check or small script that reads the same env vars as the server.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application.oneproposal.4.0.0.Validation
npm run buildnpm testnpm run typechecknpm run lintnpm run docs:check:factsnpm run ci:budgetsnpm run test:coveragenpm pack --dry-rundocker compose -f docs/examples/compose.hosted.yml configdocker build -t dokploy-mcp-http ./healthreturns OK posture JSON; unauthenticated/mcpreturns expected 401 JSON-RPC errorRelease note
Do not push tag
v4.0.0until this PR is merged. The repository release workflow is tag-driven and will publish to npm, MCP Registry, and GitHub Releases from the tag.Summary by CodeRabbit
New Features
Bug Fixes
Documentation