Fix release workflow: download native lib before tests#1236
Merged
Conversation
The release workflow ran `uv sync` + tests but never downloaded libviam_rust_utils, which uv sync does not fetch (only make install / etc/postinstall.sh does). The new spatialmath FFI tests load the native lib at runtime, so the release job failed with OSError (exit code 2). Add a postinstall step to download the lib, matching test.yml. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Ethan (stuqdog)
requested review from
Allison Chiang (allisonschiang) and
Naveed Jooma (njooma)
Member
|
Thanks for fixing that! I'm surprised it didn't get caught in the PR that introduced the spatialmath utils. |
Member
Author
Yeah, turns out the test workflow for a PR was different from the test workflow for a release in that the release workflow previously wasn't downloading rust utils. Never was an issue until we needed rust utils for unit tests! |
martha-johnston
approved these changes
Jun 30, 2026
…into fix-release-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow ran
uv sync+ tests but never downloaded libviam_rust_utils, which uv sync does not fetch (only make install / etc/postinstall.sh does). The new spatialmath FFI tests load the native lib at runtime, so the release job failed with OSError (exit code 2). Add a postinstall step to download the lib, matching test.yml.