fix(aur): do not fail a successful publish when AUR drops the connection#47
Merged
Conversation
The v0.2.0 AUR publish succeeded and the workflow reported failure: [master (root-commit) 6785b0b] Update to 0.2.0 * [new branch] HEAD -> master Connection closed by 209.126.35.78 port 22 fatal: Could not read from remote repository. The push landed -- aur.archlinux.org/packages/thinkutils shows "thinkutils 0.2.0-1" -- and it was the verification step I added one commit earlier that failed, because AUR closes the SSH connection immediately after accepting a push. Reporting failure on a successful publish is not the harmless direction of this mistake. It invites a re-run, and re-running a publish is not always harmless. So: retry ls-remote with backoff, and if AUR still cannot be reached, emit a warning naming the package page rather than failing -- git push already reported success, and an unreachable remote is not evidence the push did not land. A genuine mismatch, where the remote IS readable and disagrees, still fails. Verification steps need to distinguish "this did not work" from "I could not tell". This one conflated them.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
thinkutils | c01c09b | Jul 20 2026, 07:54 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.2.0 AUR publish succeeded and the workflow reported failure:
aur.archlinux.org/packages/thinkutilsshowsthinkutils 0.2.0-1. The package is live. What failed was thels-remotecheck I added one commit earlier — AUR closes the SSH connection immediately after accepting a push, so the second connection was refused.Why this direction matters
Reporting failure on a successful publish isn't the harmless version of this mistake. It invites a re-run, and re-running a publish is not always harmless.
Change
ls-remotewith backoffgit pushalready reported success, and an unreachable remote is not evidence the push didn't land.The general point
A verification step has to distinguish "this did not work" from "I could not tell". This one conflated them, and so produced a false negative on the very publish it was written to protect.
That's the mirror of the bug it was added for, three commits ago:
git diffnot seeing untracked files meant the workflow reported success having pushed nothing. Same workflow, opposite error, both from a check that couldn't tell the difference between an outcome and an absence of information.