Skip to content

Feat/update python 3.15#325

Open
vinitkumar wants to merge 8 commits into
masterfrom
feat/update-python-3.15
Open

Feat/update python 3.15#325
vinitkumar wants to merge 8 commits into
masterfrom
feat/update-python-3.15

Conversation

@vinitkumar

@vinitkumar vinitkumar commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Summary by Sourcery

Update multi-interpreter benchmarks and CI to target newer Python and PyPy releases while documenting the June 2026 rerun results.

New Features:

  • Document a June 2026 multi-Python CLI benchmark comparing CPython 3.14.6, CPython 3.15.0b3, PyPy 3.11.15, and a Go CLI.
  • Describe the multi-interpreter CLI rerun and its outcome in the architecture documentation.

Enhancements:

  • Retarget the multi-Python benchmark script to uv-managed CPython 3.14.6, CPython 3.15.0b3, and PyPy 3.11.15 on Apple Silicon and adjust baseline reporting.
  • Clarify BENCHMARKS instructions to reflect the current interpreter set used by benchmark_multi_python.py.

CI:

  • Pin the PyPy 3.11 CI job to a specific PyPy 3.11-v7.3.23 release and bump the Python 3.15 test matrix entry from beta.2 to beta.3.

@sourcery-ai

sourcery-ai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Updates the multi-interpreter benchmarking docs, script configuration, architecture notes, and CI matrix to target current uv-managed Python 3.14.6, CPython 3.15.0b3, and PyPy 3.11.15, while pinning CI to the matching PyPy release and refreshing benchmark results.

Flow diagram for updated multi-interpreter benchmark script

flowchart TD
  A[Start benchmark_multi_python main] --> B[Load PYTHON_VERSIONS
- CPython_3_14_6
- CPython_3_15_0b3
- PyPy_3_11_15]
  B --> C[For each interpreter
create/update venv_...]
  C --> D[Run CLI benchmarks
for each test case]
  D --> E[Collect avg_ms
per interpreter]
  E --> F[Set baseline
CPython_3_14_6]
  F --> G[Print summary table
Implementation vs CPython_3_14_6]
  G --> H[End]
Loading

File-Level Changes

Change Details Files
Refresh multi-interpreter CLI benchmark description and results to reflect the June 25, 2026 rerun with updated Python and PyPy versions.
  • Add a new Multi-Python CLI Benchmark section documenting the June 25, 2026 run, environment, and timing table across CPython 3.14.6, CPython 3.15.0b3, PyPy 3.11.15, and json2xml-go.
  • Add takeaway bullets summarizing relative performance of CPython 3.15, PyPy, and Go and clarifying that timings are end-to-end subprocess measurements.
  • Clarify the Multi-Python Version Benchmark section to state the current uv-managed interpreter targets and how to configure JSON2XML_GO_CLI.
BENCHMARKS.md
Retarget the benchmark_multi_python.py script to uv-managed, current-series CPython 3.14.6, CPython 3.15.0b3, and PyPy 3.11.15 and adjust reporting baselines accordingly.
  • Update the documented interpreter list in the header comment to the new CPython and PyPy versions.
  • Change PYTHON_VERSIONS entries to point to uv-managed interpreter paths and new virtual environment names for CPython 3.14.6, CPython 3.15.0b3, and PyPy 3.11.15.
  • Update the summary table label and baseline_name from CPython 3.14.2 to CPython 3.14.6 for relative performance comparisons.
benchmark_multi_python.py
Document the updated multi-interpreter benchmark setup and CI PyPy pinning in architecture docs.
  • Describe the June 2026 multi-interpreter CLI rerun setup and key performance conclusions, referencing benchmark_multi_python.py.
  • Explain that benchmark_multi_python.py now tracks uv-managed CPython 3.14.6, CPython 3.15.0b3, and PyPy 3.11.15 to avoid dependency on Homebrew Python.
  • Note that the GitHub Actions Python test matrix now pins its PyPy 3.11 job to a specific release to avoid silent drift in the runner cache.
lat.md/architecture.md
Update GitHub Actions Python test matrix to pin PyPy 3.11 to a specific release and track CPython 3.15.0b3.
  • Change the python-version matrix entry from pypy-3.11 to pypy-3.11-v7.3.23 to pin CI to a specific PyPy 3.11 release.
  • Update the CPython 3.15 entry in the matrix from 3.15.0-beta.2 to 3.15.0-beta.3 to align CI with the benchmarked version.
.github/workflows/pythonpackage.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.53488% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.86%. Comparing base (8dcf2ee) to head (fbe1ca1).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
json2xml/cli.py 98.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #325      +/-   ##
===========================================
- Coverage   100.00%   99.86%   -0.14%     
===========================================
  Files            6        7       +1     
  Lines          616      727     +111     
===========================================
+ Hits           616      726     +110     
- Misses           0        1       +1     
Flag Coverage Δ
unittests 99.86% <99.53%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The hard-coded uv interpreter paths in PYTHON_VERSIONS embed your home directory and uv layout; consider deriving these from environment variables or a configurable base path so the benchmark script is usable across different machines and setups.
  • The new benchmark docs reference a user-specific json2xml-go path and a very specific Apple Silicon setup; you might generalize these sections slightly (e.g., use placeholders or note they are examples) to avoid confusing contributors on other platforms.
  • In the GitHub Actions matrix, the pypy-3.11-v7.3.23 pin is helpful but somewhat opaque; consider adding a brief comment near the matrix explaining why this exact PyPy build is chosen to align with the documented 3.11.15-compatible runtime.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The hard-coded uv interpreter paths in `PYTHON_VERSIONS` embed your home directory and uv layout; consider deriving these from environment variables or a configurable base path so the benchmark script is usable across different machines and setups.
- The new benchmark docs reference a user-specific `json2xml-go` path and a very specific Apple Silicon setup; you might generalize these sections slightly (e.g., use placeholders or note they are examples) to avoid confusing contributors on other platforms.
- In the GitHub Actions matrix, the `pypy-3.11-v7.3.23` pin is helpful but somewhat opaque; consider adding a brief comment near the matrix explaining why this exact PyPy build is chosen to align with the documented 3.11.15-compatible runtime.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.


name: str

def can_handle(self, request: ConversionRequest) -> bool: ...

def can_handle(self, request: ConversionRequest) -> bool: ...

def render(self, request: ConversionRequest) -> bytes: ...
Comment thread json2xml/cli.py Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants