Feat/update python 3.15#325
Open
vinitkumar wants to merge 8 commits into
Open
Conversation
Contributor
Reviewer's GuideUpdates the multi-interpreter benchmarking docs, script configuration, architecture notes, and CI matrix to target current uv-managed Python 3.14.6, CPython 3.15.0b3, and PyPy 3.11.15, while pinning CI to the matching PyPy release and refreshing benchmark results. Flow diagram for updated multi-interpreter benchmark scriptflowchart TD
A[Start benchmark_multi_python main] --> B[Load PYTHON_VERSIONS
- CPython_3_14_6
- CPython_3_15_0b3
- PyPy_3_11_15]
B --> C[For each interpreter
create/update venv_...]
C --> D[Run CLI benchmarks
for each test case]
D --> E[Collect avg_ms
per interpreter]
E --> F[Set baseline
CPython_3_14_6]
F --> G[Print summary table
Implementation vs CPython_3_14_6]
G --> H[End]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
===========================================
- Coverage 100.00% 99.86% -0.14%
===========================================
Files 6 7 +1
Lines 616 727 +111
===========================================
+ Hits 616 726 +110
- Misses 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The hard-coded uv interpreter paths in
PYTHON_VERSIONSembed your home directory and uv layout; consider deriving these from environment variables or a configurable base path so the benchmark script is usable across different machines and setups. - The new benchmark docs reference a user-specific
json2xml-gopath and a very specific Apple Silicon setup; you might generalize these sections slightly (e.g., use placeholders or note they are examples) to avoid confusing contributors on other platforms. - In the GitHub Actions matrix, the
pypy-3.11-v7.3.23pin is helpful but somewhat opaque; consider adding a brief comment near the matrix explaining why this exact PyPy build is chosen to align with the documented 3.11.15-compatible runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The hard-coded uv interpreter paths in `PYTHON_VERSIONS` embed your home directory and uv layout; consider deriving these from environment variables or a configurable base path so the benchmark script is usable across different machines and setups.
- The new benchmark docs reference a user-specific `json2xml-go` path and a very specific Apple Silicon setup; you might generalize these sections slightly (e.g., use placeholders or note they are examples) to avoid confusing contributors on other platforms.
- In the GitHub Actions matrix, the `pypy-3.11-v7.3.23` pin is helpful but somewhat opaque; consider adding a brief comment near the matrix explaining why this exact PyPy build is chosen to align with the documented 3.11.15-compatible runtime.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| name: str | ||
|
|
||
| def can_handle(self, request: ConversionRequest) -> bool: ... |
|
|
||
| def can_handle(self, request: ConversionRequest) -> bool: ... | ||
|
|
||
| def render(self, request: ConversionRequest) -> bytes: ... |
…ed with implicit (fall through) returns' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…at/update-python-3.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update multi-interpreter benchmarks and CI to target newer Python and PyPy releases while documenting the June 2026 rerun results.
New Features:
Enhancements:
CI: