Remove perspective divide for orthographic frustum#1728
Open
rolandhill wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Robert,
I recently provided a feature in my application so the user can switch from perspective to orthographic projection. This used the vsg::Orthographic function as per the example vsgOrtho. I found the frustum clipping didn't work properly and neither did my SmallFeatureCullNode, which uses the same logic as RecordTraversal::apply(const LOD& lod).
Running
./vsgortho ../../data/models/teapot.vsgt
looks OK if you just rotate it, but once you zoom in and out it doesn't clip properly anymore.
This PR applies a fix to Frustum::computeLodScale() that fixes my application and makes the vsgOrtho teapot clip as expected as well. The only changes are in the orthographic code path.
This is beyond my maths abilities and was suggested by Claude. The AI generated explanation is below: