Consolidate Assembly Loading (#r, nuget) into one AssemblyLoadContext#498
Merged
Conversation
- Nuget: Simplify restore algorithm to use NuGet.Commands.RestoreCommand. Before, I didn't think we could access this because it's internal, but we can actually get access to it via RestoreCommandProvidersCache. This allows us to get rid of much of our customer nuget logic. - Pass all assembly loading through a new ReplAssemblyLoader class, which manages the AssemblyLoadContext. This makes sure we aren't loading subtley different DLL versions between roslyn scripting world and roslyn workspace world.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
=======================================
- Coverage 79.8% 79.5% -0.3%
=======================================
Files 123 125 +2
Lines 9316 9358 +42
Branches 1385 1395 +10
=======================================
+ Hits 7436 7445 +9
- Misses 1406 1427 +21
- Partials 474 486 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up assembly loading and resolution.
NuGet.Commands.RestoreCommand.Fixes #355, #329, #184