Feature/disk backed stream history#3415
Closed
whoisjeremylam wants to merge 134 commits into
Closed
Conversation
- Add local Go 1.26.2 and Zig 0.14.0 installs (gitignored)
- Add @go-task/cli as local npm dependency
- Update Taskfile.yml to use {{.GO}} and {{.ZIG}} vars instead of PATH
- Add go.mod stub in golang dir to prevent module scan errors
- Add manual macOS build workflow (.github/workflows/build-macos.yml)
- Update AGENTS.md with dev environment notes
- Add fork notes to README.md
- Add .pi/ to .gitignore
- Delete deploy-docsite.yml, testdriver-build.yml, testdriver.yml - Change codeql.yml to manual trigger only
Completely removes all telemetry collection, local storage, and cloud upload functionality per the remove-telemetry spec. Key changes: - Delete pkg/telemetry/, pkg/telemetry/telemetrydata/, pkg/wcloud/ - Remove telemetry loops and event recording from cmd/server/main-server.go - Remove 5 telemetry RPC commands and ActivityUpdate type from wshrpc layer - Remove telemetry call sites from wcore, conncontroller, wslconn, jobcontroller, aiusechat, panichandler, clientservice - Remove TelemetryClear/TelemetryEnabled from SettingsConfig and regenerate metaconsts.go, gotypes.d.ts, services.ts, wshclientapi.ts, wshclient.go - Remove wsh CLI activity tracking (activityWrap, sendActivity) - Remove frontend recordTEvent, ActivityCommand, RecordTEventCommand call sites - Remove Electron activity tracking (logActiveState, sendDisplaysTDataEvent, increment-term-commands IPC) - Simplify onboarding: remove telemetry toggle, NoTelemetryStarPage, and telemetry consent flow - Delete telemetry docs (telemetry.mdx, telemetry-old.mdx) - Add migration to drop db_tevent and db_activity tables Compilation fixes: - Restore services import in onboarding.tsx for AgreeTos - Fix emain/preload.ts and emain-ipc.ts corruption from incrementTermCommands removal (restore nativePaste, openBuilder, saveTextFile, setIsActive) - Fix malformed custom.d.ts type declaration - Replace remaining telemetry:enabled reads in AI panel files with true
…sections - Promote Fork Notes to ## Fork Notes immediately after intro paragraph - Remove FOSSA badge, upstream Roadmap, Links, Sponsoring sections - Remove Free Beta AI credits reference (upstream cloud service) - Remove upstream download/docs links from Installation section
- Remove entire ## Wave AI section - Remove AI references from intro and Key Features (Wave AI, AI assistants, AI chat widget) - Update Fork Notes: 'reduced AI features' -> 'remove unnecessary AI features' - Focus README on terminal, SSH, and file management capabilities
Root cause: CloseTab launched an explicit goroutine calling DestroyBlockController while DeleteTab -> DeleteBlock -> BlockCloseEvent triggered the same destruction again, causing concurrent double-Stop on ShellController and DurableShellController. Fixes: - Remove redundant DestroyBlockController goroutine from CloseTab - Add sync.Once to ShellProc.Close() as defense-in-depth - Add trace logging for interactive diagnosis - Add 14 unit tests covering the race conditions Resolves: .pi/specs/bug-tabclose-crash.md
Logging was added to verify the fix; crash confirmed resolved interactively. Stripping to avoid polluting production logs.
Logging was added to verify the fix; crash confirmed resolved interactively. Stripping to avoid polluting production logs.
… frontend - Remove AIPanel from builder-workspace.tsx, replace with placeholder div - Remove WaveAIModel imports from builder-buildpanel.tsx and builder-previewtab.tsx - Remove 'Add to Context' and 'Send Output to AI' from builder build panel - Simplify builder-previewtab ErrorStateView (remove AI streaming check/buttons) - Move formatFileSize from @/app/aipanel/ai-utils to @/util/util - Update builder-filestab.tsx formatFileSize import to @/util/util - Simplify BuilderFocusType to 'app' only, remove setWaveAIFocused() - Remove 'AI Presets' deprecated config entry and validateAiJson from waveconfig-model.ts - Remove inWaveAI parameter and WaveAI navigation branch from layoutModel.ts - Update keymodel.ts switchNodeFocusInDirection call site - Remove setWaveAIOpen from preview-electron-api.ts mock - Remove dead rateLimitInfoAtom declaration from global-atoms.ts
The inner PanelGroup (holding VTabBar + AIPanel side-by-side) was removed in Phase A, but the VTabBar's <Panel> wrapper was accidentally left intact, creating an invalid react-resizable-panels structure: a <Panel> inside another <Panel> with no <PanelGroup> parent. This caused the library to fail layout calculations and collapse all panels to zero size, producing a completely blank app window. - Replace nested <Panel> with plain <div> in workspace.tsx - Remove vtabPanelRef and ImperativePanelHandle import - Remove syncPanelCollapse() and related refs in workspace-layout-model.ts
Remove getShellIntegrationIconButton() implementation (sparkle/Claude logo and Wave AI tooltips) and replace with no-op stub returning null. - Remove TermClaudeIcon import from term-model.ts - Underlying shell integration protocol (OSC 16162) left intact; could be reused later for pi coding agent support (documented in .pi/decisions.md) Docs: Add .pi/decisions.md with Claude Code integration analysis
Move all fork planning docs into the active working directory: - Copy specs (remove-waveai, remove-telemetry, portforwarding, bug-tabclose-crash) - Copy context.md, index.md, todos.md - Merge decisions.md: prepend original ADRs (fork purpose, .pi/ hub, port forwarding config-first approach, tab-close crash fix, secret store keep) with today's Claude Code integration analysis for future pi agent support
- Delete docs/docs/waveai.mdx, waveai-modes.mdx, ai-presets.mdx - Delete schema/waveai.json, schema/aipresets.json - Remove AI config rows from docs/docs/config.mdx (ai:*, waveai:*, app:hideaibutton) - Clean AI references from gettingstarted.mdx, index.mdx, wsh-reference.mdx - Truncate releasenotes.mdx to v0.14.x, strip all AI mentions - Fix misleading AI text in builder-previewtab.tsx EmptyStateView - Remove AI schema generation from generateschema (Phase B.12 fix) - Add sharp dependency for vite image optimizer
Removes AI RPC handlers, client helpers, web endpoints, and dead packages that were missed in the original Phase B implementation. Specific changes: - wshrpctypes.go: remove 7 AI interface methods + 6 AI data types - wshserver.go: remove 5 AI RPC handlers + aiusechat/chatstore/uctypes imports - wshclient.go: remove 8 AI client helper functions + uctypes import - web.go: remove /api/post-chat-message and /wave/aichat endpoints - main-server.go: remove aiusechat.InitAIModeConfigWatcher() call - wshcmd-blocks.go: remove waveai from view filter help/validation - filebackup.go: rename waveai-backups -> file-backups - wpstypes.go: remove Event_WaveAIRateLimit and Event_AIModeConfig - tsgenevent.go: remove WaveAI event data mappings - tsgen.go: remove uctypes/AIModeConfigUpdate from ExtraTypes - Delete pkg/aiusechat/ (entire directory, ~8.5K lines) - Delete cmd/testai/, cmd/testopenai/, cmd/testsummarize/ - Delete cmd/wsh/cmd/wshcmd-ai.go (entire wsh ai command) Also updates .pi/todos.md to reflect Phase D as next active task.
Comprehensive removal of orphaned Wave AI code after Phase A/B/C cleanup: Frontend: - Delete frontend/app/aipanel/ (entire directory, 17 files) - Delete frontend/app/view/waveai/ (deprecated view) - Delete frontend/app/view/aifilediff/ (deprecated view) - Delete frontend/app/view/waveconfig/waveaivisual.tsx - Delete frontend/app/onboarding/fakechat.tsx - Delete frontend/preview/previews/waveai.preview.tsx - Delete frontend/preview/previews/aifilediff.preview.tsx + util + test Go Backend: - Remove AiSettingsType, GetAiSettings(), MergeAiSettings() from settingsconfig.go - Remove all AI fields from SettingsType (AiClear, AiPreset, AiApiType, etc.) - Remove AIModeConfigType, AIModeConfigUpdate structs - Remove WaveAIModes from FullConfigType - Remove CountCustomAIPresets(), CountCustomAIModes() methods - Remove AI meta fields from waveobj.MetaTSType (wtypemeta.go) - Remove AI fields from waveobj.ObjRTInfo (objrtinfo.go) - Delete pkg/wconfig/defaultconfig/waveai.json - Delete pkg/wconfig/defaultconfig/presets/ai.json - Clean AI defaults from pkg/wconfig/defaultconfig/settings.json - Fix embed directive in defaultconfig.go (removed all:*/*.json subdir pattern) TypeScript: - Remove setWaveAIOpen and AIModeConfigWithMode from custom.d.ts - Regenerate gotypes.d.ts, waveevent.d.ts, wshclientapi.ts (auto-cleaned) - Regenerate metaconsts.go (auto-cleaned) - Regenerate schema/settings.json (auto-cleaned) Verification: - go build ./... passes cleanly - task generate produces no AI-related output - Zero AI references remain in pkg/, cmd/, frontend/app/, frontend/preview/
Additional cleanup found during verification sweep: - Remove dangling waveAIButtonRef and hideAiButton from tabbar.tsx (ref was never attached to any DOM element, always null) - Remove app:hideaibutton from tabbarenv.ts, vtabbarenv.ts type unions - Remove hideAiButton state/checkbox from tabbar.preview.tsx, vtabbar.preview.tsx - Remove AppHideAiButton field from SettingsType - Remove app:hideaibutton default from settings.json - Remove WaveAI keybindings from docs/docs/keybindings.mdx - Regenerate gotypes.d.ts, metaconsts.go, schema/settings.json
* Remove trace logging added for tab-close crash diagnosis Logging was added to verify the fix; crash confirmed resolved interactively. Stripping to avoid polluting production logs. * Phase A review fixes: remove remaining AI references from builder and frontend - Remove AIPanel from builder-workspace.tsx, replace with placeholder div - Remove WaveAIModel imports from builder-buildpanel.tsx and builder-previewtab.tsx - Remove 'Add to Context' and 'Send Output to AI' from builder build panel - Simplify builder-previewtab ErrorStateView (remove AI streaming check/buttons) - Move formatFileSize from @/app/aipanel/ai-utils to @/util/util - Update builder-filestab.tsx formatFileSize import to @/util/util - Simplify BuilderFocusType to 'app' only, remove setWaveAIFocused() - Remove 'AI Presets' deprecated config entry and validateAiJson from waveconfig-model.ts - Remove inWaveAI parameter and WaveAI navigation branch from layoutModel.ts - Update keymodel.ts switchNodeFocusInDirection call site - Remove setWaveAIOpen from preview-electron-api.ts mock - Remove dead rateLimitInfoAtom declaration from global-atoms.ts * fix(workspace): remove invalid nested Panel causing blank screen The inner PanelGroup (holding VTabBar + AIPanel side-by-side) was removed in Phase A, but the VTabBar's <Panel> wrapper was accidentally left intact, creating an invalid react-resizable-panels structure: a <Panel> inside another <Panel> with no <PanelGroup> parent. This caused the library to fail layout calculations and collapse all panels to zero size, producing a completely blank app window. - Replace nested <Panel> with plain <div> in workspace.tsx - Remove vtabPanelRef and ImperativePanelHandle import - Remove syncPanelCollapse() and related refs in workspace-layout-model.ts * fix(term): remove AI sparkle icon from terminal block header Remove getShellIntegrationIconButton() implementation (sparkle/Claude logo and Wave AI tooltips) and replace with no-op stub returning null. - Remove TermClaudeIcon import from term-model.ts - Underlying shell integration protocol (OSC 16162) left intact; could be reused later for pi coding agent support (documented in .pi/decisions.md) Docs: Add .pi/decisions.md with Claude Code integration analysis * docs: merge .pi/ project memory from waveterm to waveterm-remote Move all fork planning docs into the active working directory: - Copy specs (remove-waveai, remove-telemetry, portforwarding, bug-tabclose-crash) - Copy context.md, index.md, todos.md - Merge decisions.md: prepend original ADRs (fork purpose, .pi/ hub, port forwarding config-first approach, tab-close crash fix, secret store keep) with today's Claude Code integration analysis for future pi agent support * Phase C: remove AI docs, schemas, and clean generator - Delete docs/docs/waveai.mdx, waveai-modes.mdx, ai-presets.mdx - Delete schema/waveai.json, schema/aipresets.json - Remove AI config rows from docs/docs/config.mdx (ai:*, waveai:*, app:hideaibutton) - Clean AI references from gettingstarted.mdx, index.mdx, wsh-reference.mdx - Truncate releasenotes.mdx to v0.14.x, strip all AI mentions - Fix misleading AI text in builder-previewtab.tsx EmptyStateView - Remove AI schema generation from generateschema (Phase B.12 fix) - Add sharp dependency for vite image optimizer * Mark builder-previewtab.tsx fix complete in todos * fix(gap): complete Phase B — remove all remaining Go backend AI wiring Removes AI RPC handlers, client helpers, web endpoints, and dead packages that were missed in the original Phase B implementation. Specific changes: - wshrpctypes.go: remove 7 AI interface methods + 6 AI data types - wshserver.go: remove 5 AI RPC handlers + aiusechat/chatstore/uctypes imports - wshclient.go: remove 8 AI client helper functions + uctypes import - web.go: remove /api/post-chat-message and /wave/aichat endpoints - main-server.go: remove aiusechat.InitAIModeConfigWatcher() call - wshcmd-blocks.go: remove waveai from view filter help/validation - filebackup.go: rename waveai-backups -> file-backups - wpstypes.go: remove Event_WaveAIRateLimit and Event_AIModeConfig - tsgenevent.go: remove WaveAI event data mappings - tsgen.go: remove uctypes/AIModeConfigUpdate from ExtraTypes - Delete pkg/aiusechat/ (entire directory, ~8.5K lines) - Delete cmd/testai/, cmd/testopenai/, cmd/testsummarize/ - Delete cmd/wsh/cmd/wshcmd-ai.go (entire wsh ai command) Also updates .pi/todos.md to reflect Phase D as next active task. * Phase D: delete all dead AI code and regenerate types Comprehensive removal of orphaned Wave AI code after Phase A/B/C cleanup: Frontend: - Delete frontend/app/aipanel/ (entire directory, 17 files) - Delete frontend/app/view/waveai/ (deprecated view) - Delete frontend/app/view/aifilediff/ (deprecated view) - Delete frontend/app/view/waveconfig/waveaivisual.tsx - Delete frontend/app/onboarding/fakechat.tsx - Delete frontend/preview/previews/waveai.preview.tsx - Delete frontend/preview/previews/aifilediff.preview.tsx + util + test Go Backend: - Remove AiSettingsType, GetAiSettings(), MergeAiSettings() from settingsconfig.go - Remove all AI fields from SettingsType (AiClear, AiPreset, AiApiType, etc.) - Remove AIModeConfigType, AIModeConfigUpdate structs - Remove WaveAIModes from FullConfigType - Remove CountCustomAIPresets(), CountCustomAIModes() methods - Remove AI meta fields from waveobj.MetaTSType (wtypemeta.go) - Remove AI fields from waveobj.ObjRTInfo (objrtinfo.go) - Delete pkg/wconfig/defaultconfig/waveai.json - Delete pkg/wconfig/defaultconfig/presets/ai.json - Clean AI defaults from pkg/wconfig/defaultconfig/settings.json - Fix embed directive in defaultconfig.go (removed all:*/*.json subdir pattern) TypeScript: - Remove setWaveAIOpen and AIModeConfigWithMode from custom.d.ts - Regenerate gotypes.d.ts, waveevent.d.ts, wshclientapi.ts (auto-cleaned) - Regenerate metaconsts.go (auto-cleaned) - Regenerate schema/settings.json (auto-cleaned) Verification: - go build ./... passes cleanly - task generate produces no AI-related output - Zero AI references remain in pkg/, cmd/, frontend/app/, frontend/preview/ * Phase D follow-up: remove missed WaveAI references Additional cleanup found during verification sweep: - Remove dangling waveAIButtonRef and hideAiButton from tabbar.tsx (ref was never attached to any DOM element, always null) - Remove app:hideaibutton from tabbarenv.ts, vtabbarenv.ts type unions - Remove hideAiButton state/checkbox from tabbar.preview.tsx, vtabbar.preview.tsx - Remove AppHideAiButton field from SettingsType - Remove app:hideaibutton default from settings.json - Remove WaveAI keybindings from docs/docs/keybindings.mdx - Regenerate gotypes.d.ts, metaconsts.go, schema/settings.json --------- Co-authored-by: Jeremy Lam <jeremy.lam@clearpool.io>
Moves all fork planning, specs, and agent context from waveterm parent to this fork repository where active development will happen. Includes: - context.md, index.md, decisions.md, todos.md - specs/ (remove-telemetry, remove-waveai, portforwarding, bug-tabclose-crash) - reviews/ (telemetry removal reviews) Updates .gitignore: - Removes .pi/ (now tracked) - Adds .pi/delegate-results/ (large session logs stay local) Also adds new high-priority bug to todos: - Tmux mouse integration lost on durable session reconnect
* fix: restore DEC private modes on durable session reconnect Tracks active DEC private modes (CSI ? h / ? l) in the frontend xterm.js instance. Persists them to the block cache file meta as 'decmodes'. On durable reconnect (when loading from cache), replays the active mode-enable sequences to the new xterm.js Terminal so its internal state matches the remote application (tmux, vim, etc). Fixes the bug where tmux mouse integration was lost after WaveTerm restart because the new terminal instance had no memory of previously-enabled modes. Changes: - pkg/service/blockservice/blockservice.go: extend SaveTerminalState with decModes param - frontend/app/view/term/termwrap.ts: track, serialize, replay DEC modes - frontend/app/store/services.ts: regenerated TS bindings Resolves #2 * fix(dec-modes): multi-param CSI tracking, clear-all reset, stale cache purge, replay whitelist - Fix CSI ? h and ? l handlers to track all parameters, not just params[0] - Fix CSI ? l with no params to clear activeDecModes (defensive) - Fix Go backend to always write decmodes meta, overwriting stale values - Add SafeReplayDecModes whitelist (1000-1006, 2004) to prevent replaying alternate screen (47/1049), cursor visibility (25), sync output (2026) Fixes gaps from af669bc reported in #2 * test(dec-modes): unit tests for DEC mode tracking with mocked xterm.js - 14 Vitest tests covering serializeDecModes, replayDecModes, and CSI handlers - Mocked Terminal, addons, and DOM to avoid heavy integration setup - Tests multi-param tracking, empty-param clear, 2026 sync transaction, whitelist filtering, and full round-trip behavior Covers gaps from af669bc reported in #2 * docs(readme): list fixed bugs in fork notes - tmux mouse integration lost on durable reconnect (01f5073, #2) - crash on tab close after SSH session exit (0cd6489)
…nect bugs issue - Moved MOSH to backlog after research: no port forwarding, no OSC52, C++ only, slow development. tsshd noted as more relevant alternative. - Added "Remote file paste" as feature task (image paste + drag-drop for SSH sessions, primary use case: pi / Claude Code TUI) - Drafted GitHub issue #4 content for auto-reconnect bugs - Priority order: auto-reconnect fixes > port forwarding > remote file paste > MOSH
…et-follow-focus spec - README: replace "MOSH support" with "remote file paste" in planned changes - Auto-reconnect draft: add missing detection (system wake, network-online, SSH keepalive), edge cases, and P0/P1/P2 priority breakdown - New spec: widget-follow-focus — system widgets inherit connection from focused terminal - Todos: reflect updated priorities
* fix(jobcontroller): P0 auto-reconnect reliability fixes - Bug #1: move cooldown timestamp set after connection check passes - Bug #2: replace processed bool with generation counters (actualGen/procGen) - Bug #3: split singleflight into reconnectConnGroup and reconnectRouteGroup - Add 12 unit tests covering all three fixes * docs: record auto-reconnect decision and tmux feature ideas from 2026-05-23 session * fix: ensure connection is alive before starting durable shell When a remote SSH connection drops (e.g. host goes down), the connection status is set to Disconnected and the route is removed from wshrouter. However, when a new block tries to start a durable shell, startNewJob() used MaybeGetConn() which returns the stale connection object without checking if it's actually alive. This adds an EnsureConnection() call before using the connection route. EnsureConnection handles reconnection for Disconnected status by calling Connect() which re-establishes the SSH session and re-registers the route in wshrouter. Fixes: durable sessions getting stuck after remote host downtime Root cause: startNewJob() assumed connection was alive without verifying
* fix(jobcontroller): P0 auto-reconnect reliability fixes - Bug #1: move cooldown timestamp set after connection check passes - Bug #2: replace processed bool with generation counters (actualGen/procGen) - Bug #3: split singleflight into reconnectConnGroup and reconnectRouteGroup - Add 12 unit tests covering all three fixes * docs: record auto-reconnect decision and tmux feature ideas from 2026-05-23 session * fix: ensure connection is alive before starting durable shell When a remote SSH connection drops (e.g. host goes down), the connection status is set to Disconnected and the route is removed from wshrouter. However, when a new block tries to start a durable shell, startNewJob() used MaybeGetConn() which returns the stale connection object without checking if it's actually alive. This adds an EnsureConnection() call before using the connection route. EnsureConnection handles reconnection for Disconnected status by calling Connect() which re-establishes the SSH session and re-registers the route in wshrouter. Fixes: durable sessions getting stuck after remote host downtime Root cause: startNewJob() assumed connection was alive without verifying * docs: setup auto-reconnect detection gaps branch — Phase 1/2/3 plan for issues #7/#8 * feat(connmonitor): auto-disconnect on persistent stall (Phase 1 — Gap C) - Add ConnStallAutoDisconnect and ConnStallDisconnectThreshold to ConnKeywords - ConnMonitor tracks StallStartTime when stall is first detected - When stall persists beyond threshold (default 30s) and user is not actively typing, trigger conn.Close() to set Status=Disconnected - This makes sleep/Wi-Fi/VPN interruptions self-healing via existing onConnectionUp - Guardrails: only disconnect when Status is Connected/Connecting; spawn Close() in goroutine to avoid blocking monitor; respect conn:stallautodisconnect=false * fix(phase1-gaps): address all GAP-1 through GAP-4 from spec review - GAP-2: Remove !urgent guard from stall-disconnect — keystrokes on a stalled connection go nowhere, so disconnect regardless of input activity - GAP-1: Add reconnect scheduler in onConnectionDown — periodic Connect() attempts (every 30s, up to 5min) for connections with running durable jobs; deduplicated via connectionReconnectSchedulers sync map - GAP-1: Add conncontroller.AttemptReconnect() helper for named reconnects - GAP-3: Add conncontroller_test.go with 11 tests for AttemptReconnect, stall tracking, disconnectOnStall, config helpers; add deduplication test in jobcontroller_test.go - GAP-4: Document conn:stallautodisconnect and conn:stalldisconnectthreshold in docs/docs/connections.mdx - Add test hooks (connectInternalTestHook, getConnectionConfigTestHook) to conncontroller package for mockability without real SSH infrastructure * docs(phase1-gaps): update spec and todos with resolution status * feat(phase2): implement NotifySystemResumeCommand for macOS sleep/wake fast-path - Replace no-op NotifySystemResumeCommand in wshserver.go with actual logic: calls jobcontroller.HandleSystemResume(ctx) - Add HandleSystemResume in jobcontroller.go: - Iterate all SSH connections via GetAllConnStatus() - Skip local, non-durable, and already-healthy connections - Force disconnect on stalled zombies (post-sleep dead TCP) - Spawn AttemptReconnect() goroutines immediately (bypass 30s scheduler) - Add hasRunningDurableJobsTestHook for testability - Add TestHandleSystemResumeSmoke in jobcontroller_test.go - Electron side already wired: emain.ts powerMonitor.on('resume') fires RPC End-to-end flow on macOS wake: 1. powerMonitor resume event → NotifySystemResumeCommand RPC 2. HandleSystemResume → disconnect stalled + AttemptReconnect for all durable conns 3. Connect() succeeds when network is back → onConnectionUp → ReconnectJob 4. Durable sessions restored in ~1-2s instead of ~60s * feat(phase3): aggressive reconnect scheduler on network-unreachable errors - Add isNetworkUnreachableError() helper: detects dial tcp i/o timeout, no route to host, network unreachable, DNS failure (no such host) - scheduleConnectionReconnect switches to aggressive mode (5s interval) when AttemptReconnect fails with a network-level error - Aggressive window extends 2 minutes per failure, catches Wi-Fi/VPN return much faster than 30s polling - Returns to normal 30s interval when aggressive window expires - Zero native code: pure Go, cross-platform, no build risk Completes the auto-reconnect trilogy: - Phase 1: Auto-disconnect on stall (keepalive timeout) - Phase 2: macOS sleep/wake fast-path (powerMonitor event) - Phase 3: Aggressive scheduler for Wi-Fi/VPN changes * docs(phase1-3): update spec with Phase 2 and Phase 3 completion status * fix(review): address critical race and timing issues from code review - Issue #1 (race): Close() in HandleSystemResume is now synchronous (not async goroutine) so status is Disconnected before AttemptReconnect - Issue #2 (double scheduler): Delete stale scheduler entry from connectionReconnectSchedulers before fast-path reconnect to avoid races - Issue #5 (timeout pile-up): In aggressive mode, connect timeout reduced from 30s -> 8s so 5s ticks don't overlap - Issue #6 (job-check timeout): Increased from 5s -> 15s so slow DB queries don't prematurely stop the scheduler
…reconnects - Set Timeout on ssh.ClientConfig so TCP dial has a fallback timeout - Enforce a 5s deadline on net.Conn during ssh.NewClientConn to prevent indefinite handshake stalls that block lifecycleLock - Clear deadline after handshake and close connection on error - Fix TimeoutFromContext to never return negative durations - Defensive ctx.Err() check in StartConnServer before reading version Fixes #13
added 27 commits
June 28, 2026 05:52
…ents Terminal: - Press Enter closes block after shell exits (both local and remote) - Message changed to '[shell terminated - press enter to close]' SCM Widget: - Header shows branch name instead of directory - Commit message text clips with ellipsis when shrunk - Side-by-side toggle disabled for untracked files (always inline) - Push button (arrow up) next to Commit button
…ivate Memoize viewText atom to avoid creating new object references when cwd hasn't changed, simplify userCwdAtom write pattern, and defer startPolling via setTimeout to avoid running during React render phase.
Eliminate the blockClicked intermediate state and its two useLayoutEffect hooks in BlockFull. The old pattern caused a synchronous re-render cascade: setBlockClicked(true) -> re-render remounts DOM -> document.activeElement lost -> focusWithin check fails -> setFocusTarget() re-focuses -> stale handleChildFocus sees isFocused=false -> calls focusNode() -> shifts layout focus to another block -> its isFocused toggles -> loop repeats. Now a single useLayoutEffect directly handles focus when isFocused becomes true, and setBlockClickedTrue handles click-based focus without going through intermediate state.
…tion gaps Root causes fixed (6): - Password prompt now renders once per tab (TabUserInputPromptOverlay), only on tabs with terminal blocks — SCM/widgets no longer show prompts - User input contexts (passphrase/password/kbd-interactive) use context.Background() instead of connection ctx — scheduler 5s timeout no longer kills the 60s password prompt window - connchange events are buffered in WPS PendingEvents so late-joining windows receive dismissal events (fixes stale prompts across windows) - Frontend no longer dismisses password prompts on non-auth connection errors — the prompt buffer is independent of connection lifecycle - Auth-failed connections no longer trigger the 5s reconnect scheduler for interactive-auth (stops prompt flashing every 5s). Instead, a background goroutine (requestPasswordRePrompt) independently re-prompts the user and retriggers Connect() when a new password is cached - Orphaned passwords (user submits after context timeout) are cached via SendUserInputResponse and consumed by connectInternal - Tab-switch reconnect trigger: when user activates a tab with disconnected/error connections, ConnEnsureCommand restarts them Design doc at .pi/specs/reconnection.md covers both strategies (autonomous vs interactive-auth) with state diagrams, UX tables, decision tree, and the full 16-trigger reference.
…, dropdown glitching Bug 1: Pass connName through tab creation chain so the backend sets connection meta on the initial block, eliminating the race between SetMetaCommand and ControllerResyncCommand that caused remote tabs to open as local. Bug 2: Add durable-disconnected check to Enter key handler so pressing Enter closes the block for durable connections when the route is disconnected, matching local/non-durable behavior. Bug 3: Reduce re-renders that caused window glitching when opening connection dropdowns — memoize BlockFrame_Header, remove global scroll capture listener, replace useLayoutEffect with useEffect for positioning calculations.
Backend returns valid empty response instead of error for non-git directories. Frontend removes inactive state checks so widget stays active with directory dropdown, polling, and empty file lists. Also changes section header action buttons to show + icon with tooltip instead of text labels.
Backend: - Add GitLookupCredentialsCommand to check secret store for stored creds - Add GitSaveCredentialsCommand to save creds to secret store - Update GitPushCommand to return authHost and authRemote - Parse remote URL to extract host and owner/repo path Frontend: - Add GitAuthDialog component with username/token fields - Add auth dialog atoms for state management - Implement silent retry with stored credentials - Show dialog on auth error or when no credentials found - Support repo-specific and host-wide credential storage Secret store naming convention: - Repo-specific: git:<protocol>:<host>/<owner>/<repo> - Host-wide: git:<protocol>:<host> Flow: - Push → auth error → check secret store → found? retry silently - Not found → show dialog → user enters creds → retry - Success → optionally save to secret store
…race, add scope tracking - encodeSecretName() replaces :/. with _ to comply with secret store's ^[A-Za-z][A-Za-z0-9_]*$ regex - detectProtocolFromURL() infers https vs ssh for secret naming - GIT_ASKPASS uses os.CreateTemp instead of fixed /tmp path (race-safe) - parseHostFromURL/parsePathFromURL exclude ssh:///https:// prefixes before matching @: pattern - authScopeAtom tracks original credential scope through dialog lifecycle - handlePush cleanup: removed dead TODO code - wshclient.go: added GitLookupCredentialsCommand and GitSaveCredentialsCommand bindings
… cached password The cached-password guard on the Status_Error branch blocked reconnection when the scheduler gave up (5 min max) leaving the connection in error state with no cached password. Tab-switch ConnEnsureCommand triggers would silently fail because EnsureConnection returned an error instead of calling Connect(). Now Connect() is always called from error state. The decoupled password callback handles prompting the user independently when needed, and the lifecycleLock/cooldown guards prevent hammering.
…ant tab trigger
EnsureConnection now always calls Connect() from Status_Error (removed
the cached-password guard that blocked reconnection after scheduler
gave up). This is critical for key-based durable connections where
switching to a disconnected tab should restart the connection.
Removed the redundant TabContent reconnect trigger. blockframe.tsx
already calls ConnEnsureCommand from its useEffect on every mount,
and blocks remount on tab switch via key={tabId}. The TabContent
trigger had a race condition where globalStore.get() reads block
metadata synchronously before blocks finish loading asynchronously,
causing an early skip that never retried.
- Center 'Authentication Required' title - Move labels to left of input fields (horizontal layout) - Change 'Token' to 'Password' with 'password or token' placeholder - Add checkbox to enable save to secrets store option - Rename options to 'This repo' and 'All repos for this remote' - Make dialog fully opaque (bg-black/80) - Add fallback for parsing remote URL when git command fails - Extract host from remote URL if authHost is empty
Before showing the auth dialog, check if there are actually unpushed commits. If there's nothing to push, return 'Everything up-to-date' success message without prompting for credentials. This prevents unnecessary auth prompts when: - Local branch is up to date with remote - No upstream is set but remote branch exists - First push with no commits yet
- Show actual git error message when auth fails (not generic message) - Show error for non-auth push failures - Handle case where result is null (dialog already shown with error)
- Add ReviewMode, JumpList, FileDiffSection, ReviewHeader components - Lazy Monaco mounting via IntersectionObserver with unmount on scroll away - Stage/unstage/revert from review mode with optimistic updates and rollback - Diff caching keyed by (path, staged, untracked) with invalidation on stage - Stats bar computing additions/deletions from diff hunks - Cross-file hunk navigation via F7/Shift+F7 using Monaco goToDiff API - Middle-click file tree entry to enter review mode for single file - Keyboard shortcuts: Escape, Alt+Up/Down, S/R keys in file header - Container-scoped keyboard listeners (not global window) - 40 unit tests for model logic and types
…exits When a remote shell exits in a durable session, no controllerstatus event with ShellProcStatus='done' was published. The frontend's key handler (shellProcStatus == 'done' && Enter) never triggered, so pressing Enter after 'shell terminated - press enter to close' did nothing. Now HandleCmdJobExited publishes the event just like ShellController does, enabling the frontend to close the block on Enter for durable sessions.
…riven edge case hardening
…se hardening - Add review-disk-backed-stream-history.md documenting 5 bugs, 5 issues, 4 gaps - Bug 1: drainRunning replaced with drainGen generation counter - Bug 2: deactivation gated on terminal event, not just catch-up - Bug 3: post-write diskFile identity check for deactivation race - Bug 5: removed dataInBuf guard, fixed diskReadPos backward-move logic - D2: diskFile.Close() moved out of lock in all paths - Tests: 7 new tests covering drain lifecycle, deactivation race, timeout, fallback
Contributor
|
Important Review skippedToo many files! This PR contains 728 files, which is 578 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (728)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Jeremy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses remote durable sessions stalling due to buffer back-pressure