Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"cli-table3": "0.6.5",
"conf": "15.1.0",
"debug": "4.4.3",
"js-yaml": "4.2.0",
"js-yaml": "^5.2.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The version specifier changed from a pinned value (4.2.0) to a semver range (^5.2.1). Every other pinned dependency in this file uses an exact version (e.g. "cli-table3": "0.6.5", "conf": "15.1.0", "debug": "4.4.3"). Using ^ here means any future npm install in CI or by a contributor could silently pull in a newer js-yaml minor that introduces additional breaking changes without a lock-file update committing to a reviewed version.

Suggested change
"js-yaml": "^5.2.1",
"js-yaml": "5.2.1",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

"node-jq": "6.3.1",
"open": "11.0.0",
"ora": "9.4.1",
Expand Down
4 changes: 2 additions & 2 deletions src/lib/output/yaml.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import yaml from 'js-yaml'
import { dump } from 'js-yaml'

/**
* @param {unknown} data
* @returns {string}
*/
export function formatYaml(data) {
return yaml.dump(data, { lineWidth: -1 }).trimEnd()
return dump(data, { lineWidth: -1 }).trimEnd()
}
Loading