Pick up tracking-loss fix: declare 'not found' when marker leaves frame#39
Open
kalwalt wants to merge 1 commit into
Open
Pick up tracking-loss fix: declare 'not found' when marker leaves frame#39kalwalt wants to merge 1 commit into
kalwalt wants to merge 1 commit into
Conversation
Pick up the tracking-loss fix (webarkit/WebARKitLib#47, #46): the tracker now declares 'not found' when the marker leaves the frame instead of staying stuck on a stale pose. Rebuild build/ + dist/ and bump the submodule. Adds the design doc. Verified with the webcam Teblid example: removing the marker hides the AR content and shows 'Searching...'; no flicker while the marker is held. Refs #36, webarkit/WebARKitLib#46, webarkit/WebARKitLib#47 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kalwalt
added
bug
github-project-automation
Bot
moved this to In progress
in New markerless image tracking
kalwalt
moved this from In progress
to Review in progress
in New markerless image tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates the WebARKitLib tracking-loss fix (webarkit/WebARKitLib#47, fixes webarkit/WebARKitLib#46): the tracker now reports
not foundwhen the marker leaves the camera frame, instead of staying stuck on a stale "Marker tracked" pose.Depends on webarkit/WebARKitLib#47 — bundled here via the submodule bump + rebuilt
build/anddist/.What's included
emscripten/WebARKitLibto the tracking-loss fix.build/webarkit_ES6_wasm.js,build/webarkit_ES6_wasm.simd.js,dist/WebARKit.js.docs/design-tracking-loss-fix.md— design + decision log + the ArtoolkitX comparison that pinpointed the bug.The fix (in WebARKitLib#47)
Two coupled changes: run the optical-flow/template-match path on
_isDetected || _isTracking(so loss is re-evaluated while tracking, not only on a fresh detection), and reset_validon template-match failure (the leak that keptisValid()true). Matches ArtoolkitX OCVT semantics (IsTrackableVisible=_isDetected || _isTracking, no lingering valid flag).Testing
Verified on the webcam Teblid example (
threejs_teblid_webcam_ES6_example.html): acquire the marker → AR content shown; remove it → content hides and status shows "Searching…" within ~1–2 frames; re-introduce → re-acquires. No flicker while the marker is held in view.Review checklist
.vscode/settings.jsonintentionally excludedRelated
Refs #36, webarkit/WebARKitLib#46
🤖 Generated with Claude Code