chore(ci): stop publishing docs from task-refactor#696
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b554229e07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| on: | ||
| push: | ||
| branches: # Allow list of deployable tags and branches. Note that all allow-listed branches cannot include any `/` characters | ||
| - next |
There was a problem hiding this comment.
Keep task-refactor package deploys running
If the goal is only to stop documentation publishes from task-refactor, removing the branch from the workflow trigger disables the entire Deploy CD workflow for that branch. In this same workflow, publish-npm still performs package versioning and deploy:npm, and publish-tag depends on it; I also checked .github/workflows and found no other workflow that publishes npm packages for task-refactor. This means pushes to task-refactor will no longer publish package prereleases/tags at all, not just skip the docs job; gate publish-documentation instead if package publishing should continue.
Useful? React with 👍 / 👎.
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
The
task-refactorbranch is currently included in the deploy workflow, and its documentation publish job force-pushes updates to thedocumentationbranch. That branch is used for the repository’s GitHub Pages site and sample app content, so changes fromtask-refactorcan unintentionally update docs/pages output even though we still want SDK publishing on thetask-refactortag path.by making the following changes
.github/workflows/deploy.ymlpublish-documentationjob to run only whengithub.ref_name == 'next'task-refactor, including SDK/package publish behaviorChange Type
The following scenarios were tested
publish-documentationis now gated tonextonlygit diff --checksuccessfullyNote:
task-refactorcurrently fail due to unrelated existing TypeScript/Jest issues in other packages, not because of this workflow-only change.The GAI Coding Policy And Copyright Annotation Best Practices
Tool used for AI assistance:
Checklist before merging