chore: remove unused @types/node-forge#5709
Open
noritaka1166 wants to merge 1 commit into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5709 +/- ##
=======================================
Coverage 76.13% 76.13%
=======================================
Files 13 13
Lines 6169 6169
=======================================
Hits 4697 4697
Misses 1472 1472 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
@types/node-forgedevelopment dependency.It was originally needed by
selfsignedv2, which depended onnode-forge.selfsignedv5 removed bothnode-forgeand its type dependency in favor of@peculiar/x509andpkijs. No source files or generated types resolvenode-forgeanymore.For context:
@types/node-forgewas added alongsideselfsignedv2.selfsignedv5 removed itsnode-forgedependency.No changeset is included because this is a maintenance-only change with no
user-facing impact.
What kind of change does this PR introduce?
chore
Did you add tests for your changes?
No. This change only removes an unused type-only development dependency.
Validated with:
npm run lint:typesnpm run lint:types-clientDoes this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No documentation updates are needed.
Use of AI
AI assistance was used to trace the dependency history, inspect the current
dependency tree and type resolution, and draft this PR description. The
resulting change and validation commands were reviewed before submission.