Skip to content

chore: remove unused @types/node-forge#5709

Open
noritaka1166 wants to merge 1 commit into
webpack:mainfrom
noritaka1166:chore/remove-unused-node-forge-types
Open

chore: remove unused @types/node-forge#5709
noritaka1166 wants to merge 1 commit into
webpack:mainfrom
noritaka1166:chore/remove-unused-node-forge-types

Conversation

@noritaka1166

Copy link
Copy Markdown
Contributor

Summary

Removes the unused @types/node-forge development dependency.

It was originally needed by selfsigned v2, which depended on node-forge.
selfsigned v5 removed both node-forge and its type dependency in favor of
@peculiar/x509 and pkijs. No source files or generated types resolve
node-forge anymore.

For context:

No changeset is included because this is a maintenance-only change with no
user-facing impact.

What kind of change does this PR introduce?

chore

Did you add tests for your changes?

No. This change only removes an unused type-only development dependency.

Validated with:

  • npm run lint:types
  • npm run lint:types-client

Does this PR introduce a breaking change?

No.

If relevant, what needs to be documented once your changes are merged or what have you already documented?

No documentation updates are needed.

Use of AI

AI assistance was used to trace the dependency history, inspect the current
dependency tree and type resolution, and draft this PR description. The
resulting change and validation commands were reviewed before submission.

@changeset-bot

changeset-bot Bot commented Jul 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d8eaecc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.13%. Comparing base (05cb792) to head (d8eaecc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5709   +/-   ##
=======================================
  Coverage   76.13%   76.13%           
=======================================
  Files          13       13           
  Lines        6169     6169           
=======================================
  Hits         4697     4697           
  Misses       1472     1472           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant