refactor(processor): extract 'Hooks' group#212
Merged
avivkeller merged 1 commit intoJul 24, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
moshams272
force-pushed
the
refactor/hooks-group-extraction
branch
from
July 24, 2026 13:26
0e4b4fb to
85dbf85
Compare
avivkeller
approved these changes
Jul 24, 2026
Member
|
Ack! My autofill auto-filled a Co-Author statement in 563732f 😭 I've co-authored so many PRs in my time it's just assuming things now. Whoops! |
Contributor
Author
Since you helped me on some decisions for this PR on Discord, I guess the autofill knows what it's doing 😂 In the end, It's a great honor for me 🤍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
Propertiessection to a standaloneHookssection underMethodssection and treat thme likeMethods.extractHooks) to resolve deeply nestedReadonlyandintersectiontypes in Webpack's hooks.arg{i}placeholders.tapabledefinitions, accurately handling Basic,BailandWaterfallhooks.refs: tapable hook types
Fixes: #206