Replace "should" with "chai"#609
Merged
Merged
Conversation
aivus
force-pushed
the
replace-should-with-chai
branch
from
7a131e4 to
b7e9623
Compare
aivus
force-pushed
the
replace-should-with-chai
branch
2 times, most recently
from
f7099a7 to
3b190b9
Compare
Resolves the 33 blocking qlty (eslint) issues reported on the PR and corrects a few artifacts left by the automated conversion: - Restore test/unit/plugins.test.js to empty (a placeholder Array#indexOf test was added by mistake) - Convert tabs/quotes/=== in test/utils/assertions.js to match style - Fix indentation and stray quotes/spaces across several test files - Add `mocha` env to .eslintrc.yml so test globals (describe/it) lint cleanly - Drop redundant duplicate `chai.should()` calls - Remove no-op `.should.be.a.string` assertions (no such chai assertion) - Drop dead `()` from `false.should.be.true()` (chai `.true` is a getter) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aivus
force-pushed
the
replace-should-with-chai
branch
from
3b190b9 to
3a477fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vibe coding with