Fix/authhelper nested api controller - #231
Open
vanterbit wants to merge 13 commits into
Open
Conversation
PHP 7.3 Fixed bug with notes on compact() function
Ввиду того что у нас шаблон advanced нам это приводит к конфликту site.com/admin/admin-payment - будет без доступа
…in route scan Da\User\Controller\api\v1\AdminController requires a UserQuery service argument in its constructor. AuthHelper::getControllerRoutes() walked into the 'api/v1' subdirectory and tried `new $className($id, $module)` for it, throwing ArgumentCountError during permission/refresh-routes. Also fixes the id-only variant of the 'admin' exclusion, which only matched at the top level (prefix + id === 'admin') and missed nested controllers named 'admin' under any sub-namespace. Cherry-picked from the upstream v1.0.23 fix (commit b9af474), rebased onto the correct xvetx\\modules\\UserManagement namespace (1.0.20) instead of the accidentally-reverted webvimark\\... namespace that v1.0.21-v1.0.23 shipped with. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.