feat: brighter ETSI buttons, copy-to-clipboard, ISO date picker#10
Merged
Conversation
- Brighten the per-message 103707/103120 buttons (solid accent border + fill) so they stand out in the record card. - Add a copy button to the XML panel that copies the pretty-printed XML to the clipboard (with a brief "copied" confirmation). - Set lang="sv-SE" on the history datetime-local input so Chrome renders it as yyyy-mm-dd instead of the en-US mm/dd/yyyy.
- Split the copy-button binary across iolist elements so it respects the elvis line_length limit (was 239 chars on one line). - Listener and history target inputs now submit on Enter, same as the button (data-on:keydown).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish on the ETSI viewer + history picker, from demo feedback.
103707 XML/103120 XMLbuttons now use a solid accent border + fill (were dim ghost buttons that blended into the card).copybutton that copies the pretty-printed XML vianavigator.clipboard, with a brief "copied" confirmation. (Clipboard API needs a secure context — works onlocalhost.)lang="sv-SE"on the historydatetime-localinput so Chrome rendersyyyy-mm-ddinstead of the en-USmm/dd/yyyy. The submitted value was already ISO; this only affects display.Local checks:
rebar3 fmt --check,xref,dialyzer,eunit(6/6) all clean.