feat: clarify history flow + local-time from-picker#11
Merged
Conversation
- History page now states it needs an active listener and that replayed messages arrive in the Receiver tab (with links to both tabs). - Interpret the datetime-local picker in the browser's local timezone: convert to epoch ms client-side (new Date) into a timestamp_ms signal; submit_history reads that directly. Drops the server-side UTC parse (ldf_format:datetime_to_ms removed) so the chosen time means local time. - Status message points the user at the Receiver tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from testing: history submits but nothing appeared, because replayed messages are delivered through the listener callback to the Receiver tab — and only if a listener exists for the target. This makes that explicit and fixes the time interpretation.
Guidance
Local time
datetime-localpicker is now interpreted in the browser's local timezone: converted to epoch ms client-side (new Date(value).getTime()) into atimestamp_mssignal, whichsubmit_historyforwards directly.ldf_format:datetime_to_ms) and its tests — the chosen time now means local wall-clock time, as expected.No change to the delivery model (still the realistic LI callback → Receiver flow).
Local checks:
rebar3 fmt --check,xref,dialyzer,eunit(3/3) clean.