Skip to content

[WPB-18127] Update email templates to v1.0.152.#5344

Open
fisx wants to merge 1 commit into
developfrom
email-templates-v1.0.152
Open

[WPB-18127] Update email templates to v1.0.152.#5344
fisx wants to merge 1 commit into
developfrom
email-templates-v1.0.152

Conversation

@fisx

@fisx fisx commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-18127

This PR is the result of following the instructions here.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx
fisx requested review from a team as code owners July 17, 2026 13:49
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 17, 2026
Comment on lines +12 to +14
You may have installed ${brand} on a new device or installed it again on an
existing one. If that was not the case, go to ${brand} Settings, remove the
device and reset your password [${forgot}].

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not look like Lithuanian

Comment on lines +21 to +22
Privacy policy and terms of use [${legal}] · Report Misuse [${misuse}]
${copyright}. ALL RIGHTS RESERVED. No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not french.

@battermann battermann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most templates are changed to English, that can't be right.

@blackheaven

Copy link
Copy Markdown
Contributor

Given that we won't include unverified/unvalidated translations, we should drop them all along, to avoid selecting fr/it/... and end up with english e-mails.

@fisx

fisx commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Given that we won't include unverified/unvalidated translations, we should drop them all along, to avoid selecting fr/it/... and end up with english e-mails.

But don't we need some default? What do you want to display instead of English if there is no translation?

@fisx

fisx commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

I talked to @Astrid-Wire, here is the conclusion:

  • we have never officially supported anything but English and German, and the unapproved translations were always provided as-is, without any promises.
  • @screendriver recently changed wire-emails to disregard unapproved emails. This is why the translations all switched to English (the default).
  • We want to stick with this change. Unapproved translations are a potential attack vector, so in emails, non-English-speaking users will be exposed to more English starting in the next release.
  • If you want to approve some of the unapproved translations and thus get them into the product again, you can reach out to Astrid and become a part-time translator.

@fisx
fisx requested review from battermann and blackheaven July 21, 2026 08:21
@fisx

fisx commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Ah, there are some legit test failures, i'll fix them and add tests for the new templates, get CI green, then it's time for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants