WPB-27060 Add optional field supportEmail to deeplink.json#5350
Open
battermann wants to merge 2 commits into
Open
WPB-27060 Add optional field supportEmail to deeplink.json#5350battermann wants to merge 2 commits into
supportEmail to deeplink.json#5350battermann wants to merge 2 commits into
Conversation
battermann
marked this pull request as ready for review
July 20, 2026 13:04
zebot
added
the
ok-to-test
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documentation and Helm chart support for an optional supportEmail field in deeplink.json, allowing clients to surface a support contact email when configured.
Changes:
- Documented the new optional
supportEmailkey in the deeplink configuration docs, including example values. - Extended the
nginzHelm chart to includesupportEmailin rendereddeeplink.jsononly when configured. - Updated the chart
values.yamlcommented examples to show how to setsupportEmail.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/src/understand/associate/deeplink.md | Documents supportEmail semantics and adds example configuration snippets. |
| charts/nginz/values.yaml | Adds commented example values for the new optional supportEmail field. |
| charts/nginz/templates/configmap.yaml | Conditionally injects supportEmail into the generated deeplink.json for both single- and multi-ingress configs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
supersven
requested changes
Jul 21, 2026
supersven
left a comment
supersven
left a comment
Contributor
There was a problem hiding this comment.
The patch itself is looking good 👍
IMHO it would look even better with a changelog entry 😉
I'm blocking merge now, because we need to align on the target branch first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-27060
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d