Skip to content

WPB-27060 Add optional field supportEmail to deeplink.json#5351

Merged
battermann merged 3 commits into
developfrom
WPB-27060-backend-add-one-field-for-support-email-in-deeplink-json-upstream
Jul 21, 2026
Merged

WPB-27060 Add optional field supportEmail to deeplink.json#5351
battermann merged 3 commits into
developfrom
WPB-27060-backend-add-one-field-for-support-email-in-deeplink-json-upstream

Conversation

@battermann

@battermann battermann commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 20, 2026
@battermann
battermann marked this pull request as ready for review July 20, 2026 13:17
@battermann
battermann requested review from a team as code owners July 20, 2026 13:17
@battermann
battermann requested a review from Copilot July 20, 2026 13:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the nginz-generated deeplink.json configuration with a new optional top-level supportEmail field, and updates the documentation and Helm values examples accordingly.

Changes:

  • Document the new optional supportEmail field in deeplink configuration docs (including examples).
  • Add commented-out supportEmail examples to the nginz Helm chart values.yaml.
  • Update the nginz Helm ConfigMap template to include supportEmail in generated deeplink.json when configured.
  • Add a changelog entry for the new field.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
docs/src/understand/associate/deeplink.md Documents supportEmail and shows it in example configs.
charts/nginz/values.yaml Adds example supportEmail configuration in commented sample values.
charts/nginz/templates/configmap.yaml Emits supportEmail into generated deeplink.json (default + multi-ingress).
changelog.d/6-federation/WPB-27060 Announces new optional supportEmail field in deeplink.json.

Comment thread charts/nginz/templates/configmap.yaml Outdated
Comment thread charts/nginz/templates/configmap.yaml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@battermann
battermann merged commit d5ec6d5 into develop Jul 21, 2026
11 checks passed
@battermann
battermann deleted the WPB-27060-backend-add-one-field-for-support-email-in-deeplink-json-upstream branch July 21, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants