F-4936 - Take parent DRBG lock around raw dispatch calls - #454
Open
ColtonWilley wants to merge 1 commit into
Open
F-4936 - Take parent DRBG lock around raw dispatch calls#454ColtonWilley wants to merge 1 commit into
ColtonWilley wants to merge 1 commit into
Conversation
wp_drbg_instantiate called the parent's get_seed/clear_seed through raw dispatch pointers with no lock, racing concurrent child instantiations on the shared primary's WC_RNG. Capture the parent's locking dispatch functions, wrap the parent calls, and propagate enable_locking one-shot, mirroring OpenSSL's PROV_DRBG. F-5186 analyzed alongside: works as designed under the EVP_RAND locking contract.
Contributor
Author
|
Jenkins retest this please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child DRBGs called the parent's get_seed/clear_seed via raw dispatch pointers with no lock held, so concurrent child instantiations (e.g. two threads' first RAND_bytes) raced on the shared primary's WC_RNG.
Fix (mirrors OpenSSL's own PROV_DRBG):
F-5186 reviewed with this: works as designed — EVP_RAND locking is opt-in and core serializes generate/uninstantiate once enabled. Full suite green, default and --enable-seed-src.