Skip to content

Add flag to use eike/json-decode-complete#318

Merged
wolfadex merged 6 commits into
mainfrom
decode-complete
Jul 11, 2026
Merged

Add flag to use eike/json-decode-complete#318
wolfadex merged 6 commits into
mainfrom
decode-complete

Conversation

@miniBill

@miniBill miniBill commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

This comment was marked as outdated.

@miniBill

miniBill commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

So the diff is because additionalProperties is not set to false for those two types, so in theory we could have a value that matches both. Which is not ideal. I don't know, maybe we can do something better?

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
diff --ignore-all-space --minimal --new-file --recursive main/cli/generated/AdditionalProperties/Json.elm branch/cli/generated/AdditionalProperties/Json.elm
20a21
> import DecodeComplete
132c133,134
<                                                         Json.Decode.succeed
---
>                                                         DecodeComplete.complete
>                                                             (DecodeComplete.object
140,141c142
<                                                             |> OpenApi.Common.jsonDecodeAndMap
<                                                                 (OpenApi.Common.decodeOptionalField
---
>                                                                 |> DecodeComplete.omissible
142a144,145
>                                                                     (Json.Decode.map
>                                                                         Just
145,146c148,149
<                                                             |> OpenApi.Common.jsonDecodeAndMap
<                                                                 (Json.Decode.field
---
>                                                                     Nothing
>                                                                 |> DecodeComplete.required
diff --ignore-all-space --minimal --new-file --recursive main/cli/generated/GithubV3RestApi/Json.elm branch/cli/generated/GithubV3RestApi/Json.elm
12604,12611c12604
<                                     ( "reviewer"
<                                     , case mapUnpack of
<                                         GithubV3RestApi.Types.SimpleUser_Or_Team__SimpleUser content ->
<                                             encodeSimpleUser content
< 
<                                         GithubV3RestApi.Types.SimpleUser_Or_Team__Team content ->
<                                             encodeTeam content
<                                     )
---
>                                     ( "reviewer", Basics.identity mapUnpack )
39280,39288c39273
<                                 (Json.Decode.oneOf
<                                     [ Json.Decode.map
<                                         GithubV3RestApi.Types.SimpleUser_Or_Team__SimpleUser
<                                         decodeSimpleUser
<                                     , Json.Decode.map
<                                         GithubV3RestApi.Types.SimpleUser_Or_Team__Team
<                                         decodeTeam
<                                     ]
<                                 )
---
>                                 Json.Decode.value
diff --ignore-all-space --minimal --new-file --recursive main/cli/generated/GithubV3RestApi/Types.elm branch/cli/generated/GithubV3RestApi/Types.elm
67c67
<     , NullableInt_Or_NullableListString_Or_NullableString(..), PrivateUser_Or_PublicUser(..), Repository_Or_StarredRepository(..), SimpleUser_Or_Stargazer(..), SimpleUser_Or_Team(..), ValidationError_Or_ValidationErrorSimple(..)
---
>     , NullableInt_Or_NullableListString_Or_NullableString(..), PrivateUser_Or_PublicUser(..), Repository_Or_StarredRepository(..), SimpleUser_Or_Stargazer(..), ValidationError_Or_ValidationErrorSimple(..)
148c148
< @docs NullableInt_Or_NullableListString_Or_NullableString, PrivateUser_Or_PublicUser, Repository_Or_StarredRepository, SimpleUser_Or_Stargazer, SimpleUser_Or_Team, ValidationError_Or_ValidationErrorSimple
---
> @docs NullableInt_Or_NullableListString_Or_NullableString, PrivateUser_Or_PublicUser, Repository_Or_StarredRepository, SimpleUser_Or_Stargazer, ValidationError_Or_ValidationErrorSimple
4474c4474
<             { reviewer : Maybe SimpleUser_Or_Team
---
>             { reviewer : Maybe Json.Encode.Value
8299,8303d8298
< 
< 
< type SimpleUser_Or_Team
<     = SimpleUser_Or_Team__SimpleUser SimpleUser
<     | SimpleUser_Or_Team__Team Team

@wolfadex wolfadex merged commit 623f5b9 into main Jul 11, 2026
3 of 4 checks passed
@wolfadex wolfadex deleted the decode-complete branch July 11, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants