feat: attribute JS package requests#294
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Takaros999
force-pushed
the
takis/idkit-react-package-metadata
branch
from
e633f86 to
1be49f7
Compare
Takaros999
force-pushed
the
takis/bridge-package-metadata-native
branch
from
a67862a to
531f593
Compare
Takaros999
force-pushed
the
takis/idkit-react-package-metadata
branch
from
1be49f7 to
fab1cf2
Compare
Takaros999
changed the title
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Takaros999
force-pushed
the
takis/idkit-react-package-metadata
branch
from
b69d012 to
3189c0f
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3189c0f61f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,7 @@ | |||
| import { createIDKitNamespace } from "@worldcoin/idkit-core/internal"; | |||
There was a problem hiding this comment.
In the publish-react workflow I inspected, the React package dependency is rewritten to the version from js/packages/core/package.json and the workflow only verifies that this version exists on npm. This new unconditional import requires the newly added @worldcoin/idkit-core/internal export, but this commit does not bump the core package version, so an independent React release can be paired with an already-published core tarball that lacks ./internal and fail on any @worldcoin/idkit import with a package-subpath export error. Please ensure core is bumped/released with this subpath before React depends on it.
Useful? React with 👍 / 👎.
Takaros999
force-pushed
the
takis/idkit-react-package-metadata
branch
from
3189c0f to
8fd3298
Compare
1 participant
stacked on top of #293, adds factory pattern
createIDKitNamespacein order to configure IDKit object with apackage_nameandpackage_version. This might sound more complex than it should be but we need it to differentiate between idkit core and react.