Document HTTP proxy configuration for WP-CLI and WordPress core - #658
Document HTTP proxy configuration for WP-CLI and WordPress core#658dilipom13 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded HTTP proxy configuration documentation for WP-CLI and WordPress core requests. The guide covers package installation, YAML settings, authentication, bypass hosts, environment variables, diagnostics, disabling, limitations, and manual proxy constants. Related handbook pages now link to the guide. ChangesHTTP proxy documentation
Estimated code review effort: 2 (Simple) | ~15 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@guides/http-proxy.md`:
- Around line 160-165: Update the configuration instructions near the
require-based setup to also document the extra-php fallback, including a short
wp config create --extra-php example or its scope and timing limitations.
- Around line 49-61: Add a prominent warning near the http-proxy YAML example
that proxy credentials, especially the password, must not be committed to
project configuration or source control. Recommend using an untracked
configuration file with restrictive permissions or injecting credentials through
a secret-management mechanism.
- Around line 63-77: Update the “Using Environment Variables” section to state
that env: true selects the first non-empty variable from HTTPS_PROXY,
https_proxy, HTTP_PROXY, and http_proxy, then applies one global proxy rather
than per-scheme proxies or bypass rules. Explicitly document that NO_PROXY and
no_proxy are unsupported, distinguish this behavior from libcurl, and explain
that callers needing bypasses should map NO_PROXY entries to bypass-hosts.
- Around line 147-152: Update the proxy credential handling around
WP_PROXY_USERNAME and WP_PROXY_PASSWORD to URL-decode the parsed username and
password values before defining the constants, while preserving the existing
empty-value checks and constant definitions.
- Around line 135-145: Update the proxy configuration flow after parse_url to
require a valid proxy port, deriving one when appropriate if the URL omits it,
before defining WP_PROXY_HOST. Ensure WP_PROXY_PORT is always defined alongside
WP_PROXY_HOST so WordPress proxy support is enabled only with a valid host and
port.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a6f322d6-32ab-41ec-be2f-8a63dcc95484
📒 Files selected for processing (6)
bin/handbook-manifest.jsonguides.mdguides/http-proxy.mdguides/troubleshooting.mdindex.mdreferences/config.md
|
See also #654 |
Thanks @swissspidy for pointing to #654. Happy to combine efforts , please let me know |
Clarify credential handling, env var behavior, port requirements, URL-decoded auth values, and the extra-php fallback option.
Fixes #601
Adds HTTP proxy configuration documentation for WP-CLI and WordPress core requests.
guides/http-proxy.mdekamran/wp-cli-http-proxy-commandpackageSummary by CodeRabbit
New Features
Documentation
HTTP_PROXYandHTTPS_PROXYenvironment variables are not automatically honored.