Upgrade Android embedding to v2#25
Open
ttyniwa wants to merge 8 commits into
Open
Conversation
Created EmbeddingV1Activity file that uses the v1 embedding for the example project.
* fix EmbeddingV1Activity plugin name. * end of line break.
ttyniwa
changed the title
… officially. > The scripts generated by this task are intended to be committed to your version control system. This task also generates a small gradle-wrapper.jar bootstrap JAR file and properties file which should also be committed to your VCS. The scripts delegates to this JAR. > https://docs.gradle.org/current/dsl/org.gradle.api.tasks.wrapper.Wrapper.html
Contributor
Author
|
I tested that this PR works on Android 8. |
|
Hi @ttyniwa I tried ur code but got an error "lambda expressions are not supported in -source 7 vscode" I think using lambda not working for me when building the app. |
|
@andrey-ushakov can we merge this to master? |
|
can this PR be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR solves #23
This PR works on Android 8.
I'm new to Flutter Plugin development and Android development, so there may be some oddities.
so, If the PR is not good enough, I don't mind if you close it.
References.
https://flutter.dev/docs/development/packages-and-plugins/plugin-api-migration
https://flutter.dev/docs/development/packages-and-plugins/developing-packages#plugin