feat(storage): support public MinIO reverse-proxy URLs - #859
Closed
Nickszy wants to merge 1 commit into
Closed
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
Author
|
关闭此版本:上游 main 已在 #852 后引入 MINIO_PUBLIC_URL=/minio 的同源反代方案,覆盖了本 PR 的主要功能且目录重构导致实现冲突。我会基于当前架构另提一个仅修复 URL 校验/前缀解析的最小 PR,避免重复功能。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow deployments that keep MinIO private and expose objects through an application reverse proxy.
MINIO_PUBLIC_URI(for examplehttps://yuxi.example.com/storage).:9000.HOST_IP/ localhost behavior whenMINIO_PUBLIC_URIis unset.Why
Many production deployments do not publish MinIO directly. Returning
http://<host>:9000/...produces inaccessible or mixed-origin URLs; the configurable public base allows same-origin reverse-proxy deployments without weakening URL validation.Tests
The focused test module loads the storage client without importing the application's eager graph bootstrap, so it has no Neo4j dependency.