Fix: give feedback when target url already exists#4
Open
ShunLuk wants to merge 1 commit into
Open
Conversation
ShunLuk
requested review from
Rovasch,
SimonvanWijhe,
Copilot,
dtakken,
ictbeheer,
mvdhoek1 and
rivanuff
There was a problem hiding this comment.
Pull request overview
This PR adds multisite network-admin feedback when attempting to update a site’s URL to a domain/path that is already used by another site, preventing the change and showing an error notice.
Changes:
- Hook into the network “Edit Site → Site Info” save flow to detect “domain already exists” conflicts.
- Redirect back to the site info screen with a query flag when the target domain/path is taken.
- Display a network admin notice explaining that the URL was not changed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+79
to
+92
| $scheme = parse_url(get_blog_option($id, 'siteurl'), PHP_URL_SCHEME) ?: 'https'; | ||
| $newUrl = wp_unslash((string) $_POST['blog']['url']); | ||
|
|
||
| if (! parse_url($newUrl, PHP_URL_SCHEME)) { | ||
| $newUrl = $scheme . '://' . $newUrl; | ||
| } | ||
|
|
||
| $parsed = parse_url($newUrl); | ||
| $newDomain = $parsed['host'] ?? ''; | ||
| $newPath = trailingslashit('/' . trim($parsed['path'] ?? '/', '/')); | ||
|
|
||
| if (! $newDomain) { | ||
| return; | ||
| } |
| return; | ||
| } | ||
|
|
||
| wp_admin_notice(__('A site with that domain already exists. The URL was not changed.'), [ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.