DEV-4893: backfill recorder/devbar hardening tests#17
Open
ytspar wants to merge 1 commit into
Open
Conversation
The three cycle-1-deferred unit tests for the DEV-4874 hardening fixes (landed in #16), as a test-only follow-up: - recording.test.ts: stopRecording logs the null-video warning + writes a manifest with video undefined when page.video() is null; getRecordingStatus is pause-aware (duration excludes the open + accumulated pause windows). - websocket.test.ts: record-start-response clears a stale optimistic timer before starting its own (leak fix), and rolls back the optimistic UI on a success:false response. Test-only (111/111 in the two files). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ytspar
commented
Jun 22, 2026
ytspar
left a comment
ytspar
left a comment
Owner
Author
There was a problem hiding this comment.
AI review (advisory) — cycle 1
Per the MR Review SOP, this is advisory only.
Reviewed against:5d2ef0f
Summary
Test-only backfill of the three cycle-1-deferred unit tests for the DEV-4874 recorder/devbar hardening (landed in #16). No source changes — pure coverage; re-homed onto current main after #16 squash-merged.
Findings
blocker: none.
recording.test.ts— null-page.video()warning +video-undefined manifest on stop;getRecordingStatuspause-aware (excludes open + accumulated pause windows).websocket.test.ts—record-start-responseclears a stale optimistic timer before starting its own (the DEV-4874 leak fix), and rolls back the optimistic UI onsuccess:false.- Both suites green: 111/111. Test-only diff.
Recommendation
APPROVE
Verdict (5d2ef0f): APPROVE
Self-authored PR → author can't self-approve; this documents the review. Test-only + green; awaiting a non-author teammate to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backfill the three cycle-1-deferred unit tests for the DEV-4874 recorder/devbar hardening (landed in #16). Test-only follow-up; closes the DEV-4893 tracker.
Tests added
recording.test.ts— (1)stopRecordinglogs the null-video warning + writes a manifest withvideoundefined whenpage.video()is null; (2)getRecordingStatusis pause-aware (duration excludes the open + accumulated pause windows).websocket.test.ts— (3)record-start-responseclears a stale optimistic timer before starting its own (the leaked-interval fix); (4)success:falserolls back the optimistic "recording" UI.Testing
recording.test.ts+websocket.test.ts: 111/111 pass. Test-only — no source changes.