[Doc] Use callable name in HTTP server example tool list#6
Closed
yuki3738 wants to merge 1 commit into
Closed
Conversation
The HTTP server example's "Tools" list referred to the adder tool by its class name `ExampleTool`, while the sibling `echo` tool is listed by its callable name. The tool is registered from the `ExampleTool` class without an explicit `tool_name`, so its callable name is `example_tool` (derived via `StringUtils.handle_from_class_name`). List it by the callable name for consistency with `echo` and with the `tools/call` examples. Breaking Changes: None (documentation only).
7 tasks
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The HTTP server example's "Tools" list in
examples/README.mdrefers to the adder tool by its class nameExampleTool, while the siblingechotool is listed by its callable name. The tool is registered from theExampleToolclass without an explicittool_name, so its callable name isexample_tool(derived viaStringUtils.handle_from_class_name).This lists it by the callable name, consistent with the
echoentry beside it and with thetools/callexamples further down.How Has This Been Tested?
N/A (documentation only). The listed name now matches the tool registered by
examples/http_server.rb.Breaking Changes
None (documentation only).
Types of changes
Checklist