add reshape codec#82
Open
konstibob wants to merge 2 commits into
Open
Conversation
split up functions in reshape to make more readable split up resolveOutputShape
normanrz
approved these changes
Jul 21, 2026
normanrz
left a comment
normanrz
left a comment
Member
There was a problem hiding this comment.
Looks good, just a few minor notes.
| "reshape codec received an array of shape " + Arrays.toString(chunkArray.getShape()) | ||
| + " but expected the chunk shape " + Arrays.toString(inputShape) + "."); | ||
| } | ||
| int[] outputShape = resolveOutputShape(inputShape); |
Member
There was a problem hiding this comment.
The outputChunkShape is computed in every encode and decode call. It could be cached as a protected property of the class, because it is only changed when the arrayMetadata changes. You can override the setCoreArrayMetadata metadata, compute the outputChunkShape there, and use the property in encode and decode.
| // decode is the inverse of encode. | ||
| ucar.ma2.Array decoded = codec.decode(encoded); | ||
| Assertions.assertArrayEquals(inputShape, decoded.getShape()); | ||
| assert MAMath.equals(input, decoded); |
Member
There was a problem hiding this comment.
The assert keyword should not be used. Replace with:
Suggested change
| assert MAMath.equals(input, decoded); | |
| Assertions.assertTrue(MAMath.equals(input, decoded)); |
| .withDataType(DataType.UINT32) | ||
| .withChunkShape(4, 5, 6, 3) | ||
| .withFillValue(0) | ||
| .withCodecs(c -> c.withReshape(new Object[]{new int[]{0, 1}, new int[]{2}, 3}).withZstd()); |
Member
There was a problem hiding this comment.
Once we landed #81, we should add a test that uses reshape + jpeg. Because reshape does not alter the byte-layout, this test doesn't do much. Still useful, though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a spec-compliant ReshapeCodec zarr-developers/zarr-extensions#10 in zarr-java plus tests, all passing.