feat: add shared HTTP sessions and configurable timeouts - #255
Closed
Mattsface wants to merge 1 commit into
Closed
Conversation
Use a shared requests.Session for v1 and v1.1 adapters, require an explicit timeout on every request, support session injection with clear ownership rules, and add close()/context-manager cleanup on Mlb. Co-authored-by: Matthew Spah <spahmatthew@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The HTTP adapter used module-level
requests.get(), which prevented connection reuse, made timeouts/session injection awkward, and left no clear cleanup path. Every request also needs an explicit timeout so the library cannot hang indefinitely waiting on the MLB API.What
requests.SessionMlbclient's v1 and v1.1 adapters(3.05, 30.0)and allow scalar/tuple overridessession=injection onMlb/MlbDataAdapterMlb.close()plus context-manager support (with Mlb() as mlb:)tests/test_mlb_session.pyTests
poetry run pytest tests/ --ignore=tests/external_tests— 116 passedpoetry run pytest tests/external_tests/mlbdataadapter/— 3 passedRisk and impact
Intentionally left out