Skip to content

1ms delay to data loop.#75

Open
phuein wants to merge 1 commit into
zeth:masterfrom
phuein:master
Open

1ms delay to data loop.#75
phuein wants to merge 1 commit into
zeth:masterfrom
phuein:master

Conversation

@phuein

@phuein phuein commented Apr 24, 2019

Copy link
Copy Markdown

Overloads the CPU otherwise. The While loop should at least take 1ms.

Overloads the CPU otherwise. The While loop should at least take 1ms.
@phuein

phuein commented Apr 24, 2019

Copy link
Copy Markdown
Author

#65 Discussion

@jagprog5

Copy link
Copy Markdown

👍

@gaafiz

gaafiz commented Mar 19, 2020

Copy link
Copy Markdown

Is this going to be merged?

@barrettford

Copy link
Copy Markdown

So... we gonna merge this?

@SpotlightKid

Copy link
Copy Markdown

This is not the right way to fix this, IMO. The sleep does not belong in the _do_iter method. Just put in the loop in your own code where you iterate over the InputDevice instance.

@zeth

zeth commented Dec 17, 2020

Copy link
Copy Markdown
Owner

This is not the right way to fix this, IMO. The sleep does not belong in the _do_iter method. Just put in the loop in your own code where you iterate over the InputDevice instance.

This is what I thought. At least we should use asyncio or something so the user has control.

The original platform this was aimed at was Raspberry Pi then I tested it on Linux, Mac and Windows on thirty input devices.

(BTW If the delay is really needed on Windows then any solutions should only be on Windows, which to be fair I think this is. I don't feel I know enough yet to make changes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants