-
Notifications
You must be signed in to change notification settings - Fork 17
Add move_object atomic action #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
skywhite1024
wants to merge
14
commits into
main
Choose a base branch
from
ljd/move_object_atomic_actions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
aad9cc3
Add upright atomic action
skywhite1024 d258064
Address upright action review feedback
skywhite1024 5552597
Address upright action follow-up fixes
skywhite1024 0561aae
wip
yuecideng 74fbe43
wip
yuecideng 9da06f9
wip
yuecideng 2aaac19
wip
yuecideng ddd1236
Add move object atomic action
skywhite1024 dfc0800
Keep move_object demo hold-only
skywhite1024 bb41004
add pickup_atomic_actions.py
skywhite1024 9eb8fb4
Address atomic action review feedback
skywhite1024 7f808b6
Address move object atomic action review feedback
skywhite1024 6cc298a
Minimize pickup changes for move object action
skywhite1024 ef98a81
Fix batched pickup success handling
skywhite1024 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add docs and unitest for the new atomic action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added both.
Docs now cover:
MoveObjectActionMoveObjectActionCfgMoveObjectTargetHeldObjectStateMoveObjectTarget/{"object_target_pose": ...}Tests now cover:
MoveObjectActiontarget resolution