Skip to content

fix(run-info): add PERIODTYPE to hardware info dropdown #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
64johnlee wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

fix(run-info): add PERIODTYPE to hardware info dropdown #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/components/Instrument.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ export class Instrument {
pvaddress: `${this.prefix}DAE:PERIODSEQ`,
human_readable_name: "Period Sequence",
},
{
pvaddress: `${this.prefix}DAE:PERIODTYPE`,
human_readable_name: "Period Type",
},
{
pvaddress: `${this.prefix}DAE:GOODFRAMES_PD`,
human_readable_name: "Period Good Frames",
Expand Down
14 changes: 14 additions & 0 deletions app/components/__snapshots__/TopBar.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,20 @@ exports[`renders topbar unchanged 1`] = `
class="break-all"
/>
</div>
<div
class="mb-2 shadow-xs rounded-md"
>
<p
class="font-bold"
>
Period Type
:
</p>

<p
class="break-all"
/>
</div>
<div
class="mb-2 shadow-xs rounded-md"
>
Expand Down